Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MUSIC][AUDIOBOOKS] Fix last chapter duration #26143

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

the-black-eagle
Copy link
Contributor

Description

Fixes an issue with the last chapter of m4b audiobooks where the duration is either missing or wrong.

Motivation and context

Forgot originally to convert seconds to milliseconds for the duration of the last chapter.

How has this been tested?

Scanned some m4b audiobooks and observed that the last chapter in all cases has the correct duration now.

What is the effect on users?

m4b books display the correct duration for the last chapter.

Screenshots (if appropriate):

Before :

Screenshot from 2024-12-21 15-14-43

After :
Screenshot from 2024-12-21 14-58-22

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@the-black-eagle the-black-eagle added Type: Fix non-breaking change which fixes an issue Component: Music v22 Piers labels Dec 21, 2024
@the-black-eagle the-black-eagle added this to the Piers 22.0 Alpha 1 milestone Dec 21, 2024
Copy link
Member

@neo1973 neo1973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have audio books to test but it looks like a proper fix 👍

@the-black-eagle the-black-eagle merged commit ecc600c into xbmc:master Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Music Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants