-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service.plexskipintro] 1.0.0 #2221
base: matrix
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please start with my initial comments. I (or someone else) will re-review it after the initial fixes.
@@ -0,0 +1,30 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't submit .github
files in a PR.
@@ -0,0 +1,18 @@ | |||
### Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't submit github files in a PR.
@@ -0,0 +1,95 @@ | |||
### Introduction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't submit github files in a PR.
service.plexskipintro/addon.xml
Outdated
<description lang="en">Prompt a Skip Intro dialog Netflix style using plex metadata. Skips intro for your favourite shows</description> | ||
<summary lang="en">Skip TV Shows Intro</summary> | ||
<platform>all</platform> | ||
<forum>-</forum> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fill out all the information and add the SDPX for the license.
import time | ||
|
||
def closeDialog(): | ||
global Dialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are all these globals
in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these globals are being used to pass around values between defs for various variables such as the times of the intro or the dialog to be displayed/hidden
Ping @Darkmadda |
Requested as in review suggestion
Requested as in review suggestion
CR fixes
CR fix
Description
Checklist:
Additional information :