Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.viwx] v1.5.2 #4607

Open
wants to merge 1 commit into
base: matrix
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions plugin.video.viwx/addon.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<addon id="plugin.video.viwx" name="viwX" version="1.5.1" provider-name="Dimitri Kroon">
<addon id="plugin.video.viwx" name="viwX" version="1.5.2" provider-name="Dimitri Kroon">
<requires>
<import addon="xbmc.python" version="3.0.0"/>
<import addon="inputstream.adaptive" version="19.0.5"/>
Expand Down Expand Up @@ -30,18 +30,9 @@
<fanart>resources/fanart.png</fanart>
</assets>
<news>
[B]v1.5.1[/B]
[B]v1.5.2[/B]
[B]Fixes:[/B]
* News clips failed to play with KeyError 'Brand'.
* Error messages when opening an empty 'Continue Watching' list.
* Stream-only FAST channels stalled in advert breaks.
* Programmes are now reported as having been fully played when the user has skipped to the end while playing.
* Some programmes were missing en IPTV EPG.
* Search now requests the same number of items as a generic web browser does.

[B]New Features:[/B]
* Paid items are excluded from search results based on the setting 'Hide premium content'.
* On most live channels it's now possible to seek back up to 1 hour from the moment the channel is started.
- Login failed with error 'Forbidden' even though email and password were correct.
</news>
<reuselanguageinvoker>true</reuselanguageinvoker>
</extension>
Expand Down
4 changes: 4 additions & 0 deletions plugin.video.viwx/changelog.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
v 1.5.2
Fixes:
- Login failed with error 'Forbidden' even though email and password were correct.

v 1.5.1
Fixes:
- News clips failed to play with KeyError 'Brand'.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,19 +181,19 @@ msgid "Signed out!"
msgstr ""

msgctxt "#30614"
msgid "User name"
msgid "Email"
msgstr ""

msgctxt "#30615"
msgid "Password"
msgstr ""

msgctxt "#30616"
msgid "Invalid username"
msgid "Invalid email or password"
msgstr ""

msgctxt "#30617"
msgid "Invalid password"
msgid "Forbidden\nIf this error persists wait a few hours before trying again."
msgstr ""

msgctxt "#30618"
Expand Down
10 changes: 7 additions & 3 deletions plugin.video.viwx/resources/lib/itv_account.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import json
import logging

from codequick import Script
from codequick.support import logger_id

from . import utils
Expand All @@ -21,6 +22,9 @@
logger = logging.getLogger(logger_id + '.account')
SESS_DATA_VERS = 2

TXT_INVALID_EMAIL_OR_PASSW = 30616
TXT_LOGIN_FORBIDDEN = 30617


class ItvSession:
def __init__(self):
Expand Down Expand Up @@ -123,7 +127,7 @@ def login(self, uname: str, passw: str):
'sec-fetch-dest': 'empty',
'sec-fetch-mode': 'cors',
'sec-fetch-site': 'same-site',
'priority': 'u=1',
'priority': 'u=0',
'te': 'trailers'
},
timeout=fetch.WEB_TIMEOUT
Expand All @@ -141,8 +145,8 @@ def login(self, uname: str, passw: str):
status_code = e.response.status_code
if status_code in (400, 403):
msg = {
400: 'Invalid username or password',
403: 'Forbidden\nIf this error persists wait a few hours before trying again.'
400: Script.localize(TXT_INVALID_EMAIL_OR_PASSW),
403: Script.localize(TXT_LOGIN_FORBIDDEN)
}.get(status_code, 'Sign in failed.')
logger.info("Sign in failed: %r: %r", e, e.response.content)
raise AuthenticationError(msg) from None
Expand Down
9 changes: 1 addition & 8 deletions plugin.video.viwx/resources/lib/kodi_utils.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ----------------------------------------------------------------------------------------------------------------------
# Copyright (c) 2022-2023 Dimitri Kroon.
# Copyright (c) 2022-2024 Dimitri Kroon.
# This file is part of plugin.video.viwx.
# SPDX-License-Identifier: GPL-2.0-or-later
# See LICENSE.txt
Expand Down Expand Up @@ -30,8 +30,6 @@

TXT_USERNAME = 30614
TXT_PASSWORD = 30615
TXT_INVALID_USERNAME = 30616
TXT_INVALID_PASSWORD = 30617
TXT_TRY_AGAIN = 30618
TXT_RESUME_FROM = 30619
TXT_PLAY_FROM_START = 30620
Expand Down Expand Up @@ -88,11 +86,6 @@ def show_login_result(success: bool, message: str = None):
def ask_login_retry(reason):
"""Show a message that login has failed and ask whether to try again."""

if reason.lower() == 'invalid username':
reason = Script.localize(TXT_INVALID_USERNAME)
elif reason.lower() == 'invalid password':
reason = Script.localize(TXT_INVALID_PASSWORD)

msg = '\n\n'.join((reason, Script.localize(TXT_TRY_AGAIN)))

dlg = xbmcgui.Dialog()
Expand Down
31 changes: 20 additions & 11 deletions plugin.video.viwx/resources/lib/telemetry_data.py

Large diffs are not rendered by default.

Loading