[AdaptiveTree] Rework of manifest update params #1288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After reading DASH specs for "MPD update" the "type" tag must be present in the MPD to distinguish LIVE and VOD content,
so i made the decision to remove the "full" parameter of
inputstream.adaptive.manifest_update_parameter
then cleanup and rework related variables, now if a MPD is declared dynamic we always enable manifest updates.the old
inputstream.adaptive.manifest_update_parameter
property is now deprecated and replaced byinputstream.adaptive.manifest_upd_params
that has the same meaning, butI do not know if there are any other video services that use it except youtube
breaking change because "full" behaviour is removed,
@glennguy if you have some other live MPDs to test try play them
in the
DASHTreeTest
i have introduced a way to make manifest update tests which can be expanded as needs seeupdateParameterLiveSegmentStartNumber
Motivation and context
Followup of PR #1267 to finish wip changes
How has this been tested?
from what i understand there can be two main cases for live:
tests for points above:
Screenshots (if appropriate):
Types of change
Checklist: