Kodi Player.Seek now requires an object with percentage argument #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and works fine. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since xbmc/xbmc@3801ec4 the Player.Seek JSON-RPC command in Kodi 19 no longer interprets a single numeric parameter as the percentage to seek to; it requires an object with a member "percentage".
I made an attempt at fixing this, though I've never worked on CoffeeScript before, so this change should be checked carefully by someone more clue-ful. I have tested that this makes seeking by clicking on the progress bar work, when before it didn't work on Kodi 19 Alpha. I've tested that seeking in the local player also works.