-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced ActsAsTaggableOnSteroids by ActsAsTaggableOn #99
Conversation
… occure in the test case
…een pg and sqlite. This should be thought of for future test cases
I am sorry I could not fix the build error with ruby1.9.3. |
I think doing something about I haven't had a chance to dig into this too much yet, but just a hunch: the Travis build error where it's complaining that for Ruby 1.9.3 "An error occurred while installing rspec-activemodel-mocks (1.0.1)" could be related to a temporary fix (4d0cd84) that's still present in the codebase and I think should be able to be removed now and replaced with the official rspec-activemodel-mocks 1.0.2. Or this could just be a weird coincidence. The other issue that occurs to me is related to existing users. If this commit drops the existing tag-related tables, then that potentially nukes existing user's tags. A smooth upgrade path of some kind would be preferable here, IMO. @xaviershay, any thoughts? I won't have time to look further into this for maybe a couple of weeks. But if anyone else wants to take on further investigation, please do. |
Thank you for the reply, @gaelian. I will look into these issues during the next days. Concerning the second issue: I will think about a way to fix this. As those two modules are closely related it should be easy to transfer old data by not dropping and recreating the tables. So i will most probably rewrite the migrations into one that updates the tables instead of recreating them. |
…nged to allow upgrade of running blogs without data loss
…to work propperly
I tried to address the two issues and it seems as if I have fixed them. It would be a great thing if anyone with real data could try the migration once (on a COPY of the real data!!!) to confirm it really does what it should. Using some test data everything seemed fine. |
Replaced ActsAsTaggableOnSteroids with ActsAsTaggableOn.
@rueckerl thanks for the contribution! 👍 |
I tried to get rid of the ActsAsTaggableOnSteroids as i got some errors related to it.
I replaced it by ActsAsTaggableOn which is quite similar.
The main advantage is, that now it is a gem and not a copied library that is used.
Changes include: