Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite quantify and dequantify #17

Merged
merged 38 commits into from
Jul 17, 2020
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
6209c98
add a function to extract / retrieve unit attributes
keewis Jul 11, 2020
0edc9fc
add a function to zip mappings
keewis Jul 11, 2020
05ff46a
partially rewrite Dataset.pint.quantify
keewis Jul 11, 2020
a831408
add tests for the unit attribute extraction function
keewis Jul 13, 2020
a4dd9e5
also make sure that deleting attributes works
keewis Jul 13, 2020
96d64c9
add a function to attach units as string attributes
keewis Jul 13, 2020
5cb7605
also extract unit attributes from variable objects
keewis Jul 13, 2020
33e6027
refactor the unit attr extraction tests
keewis Jul 13, 2020
0dbec68
allow using a different attr name
keewis Jul 13, 2020
cb2fa65
use the conversion functions to implement dequantify
keewis Jul 13, 2020
29add91
update the docs on the return value
keewis Jul 13, 2020
a8b14af
update the conditions for _decide_units
keewis Jul 13, 2020
1fde9a0
rewrite the Dataset quantify and dequantify methods
keewis Jul 13, 2020
6868442
raise on unit stripped warnings
keewis Jul 14, 2020
68df60c
remove the test checking that dequantify raises if there were no quan…
keewis Jul 14, 2020
ce40356
make sure Dataset.pint.quantify raises only if we would overwrite a q…
keewis Jul 14, 2020
c4dca20
don't try to put units in indexes
keewis Jul 14, 2020
61cc2e0
check the attributes after dequantify more thoroughly
keewis Jul 14, 2020
43e91f0
make sure the attributes are strings
keewis Jul 14, 2020
c1c5e52
move the str conversion of pint.Unit to a util function
keewis Jul 14, 2020
1ead700
update the dequantify docstrings
keewis Jul 14, 2020
a34c753
update the quantify docstrings
keewis Jul 14, 2020
66cfdbd
add tests for Dataset.pint.dequantify
keewis Jul 14, 2020
ee036b3
update the parameter spec of Dataset.pint.quantify
keewis Jul 14, 2020
75d26ad
remove the old attach and quantify functions
keewis Jul 14, 2020
72c6cb9
fix the template used to format accessor attributes
keewis Jul 14, 2020
bb38e64
remove the attrs on quantify
keewis Jul 14, 2020
fc5d615
make the description of the units kwargs easier to understand
keewis Jul 14, 2020
c4f74db
mention the format of the units
keewis Jul 14, 2020
4fdf8e8
Merge branch 'master' into quantify
keewis Jul 14, 2020
ac63a01
don't use rst references in the descriptions in docstrings
keewis Jul 14, 2020
7e16985
warn about loading data into memory while quantifying
keewis Jul 14, 2020
131403c
don't try to quantify indexes
keewis Jul 15, 2020
f764586
replace the delete parameter with a strip function
keewis Jul 15, 2020
e703909
update the docstrings
keewis Jul 15, 2020
f6e0882
more docstring updates
keewis Jul 15, 2020
9d59e6f
Merge branch 'master' into quantify
keewis Jul 17, 2020
08b2c1e
use K instead of degK
keewis Jul 17, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into quantify
keewis committed Jul 17, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 9d59e6ffd48e1e1323869364f9267f2a8a077001

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.