Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import and call the env analysis script #4

Merged
merged 50 commits into from
Nov 18, 2024
Merged

import and call the env analysis script #4

merged 50 commits into from
Nov 18, 2024

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Nov 11, 2024

keewis added 30 commits November 11, 2024 13:11
@keewis
import the script
4b21130
@keewis
list the dependencies
3d9eff3
@keewis
call the script from within the action
3b4c189
@keewis
explicitly specify the shell
416fbfe
@keewis
Merge branch 'main' into script
79ba941
@keewis
quote the envs-path variable
d398fac
@keewis
try setting the input type of env-paths
9f59968
@keewis
try serializing to json
c0f3614
@keewis
quote the input
670a623
@keewis
missing shell
80652c1
@keewis
correct the input name
70b826c
@keewis
print the decoded paths
23fcf82
@keewis
typo
689c049
@keewis
use the right function names
5773e7c
@keewis
unquote
a2b494c
@keewis
try using join
03b5e25
@keewis
remove debug step
1f48cd0
@keewis
allow expected failures
9094fb2
@keewis
add test env files
f823a9a
@keewis
compare strings instead
56649b6
@keewis
pass expected failure as a list
2b90a42
@keewis
another failing example
5bb582c
@keewis
show the status of the current dir
a45662b
@keewis
more debugging
b470c76
@keewis
print the content of envs
2866cda
@keewis
rename env1
906112e
@keewis
use a existing version of pandas
4c0f2d4
@keewis
use an existing version of packaging
211a609
@keewis
enforce a column width of 120
132fef7
@keewis
proper syntax
16ba62b
@keewis
Copy link
Contributor Author

keewis commented Nov 11, 2024

Will need more python tests, but this does include all the failure conditions in the end-to-end tests. We'll need to figure out how to automatically bump the failing envs, though.

mathause
mathause reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I made you some work it seems 😄

envs/env1.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Move to a tests folder?

keewis
keewis commented Nov 11, 2024
View reviewed changes
Copy link
Contributor Author

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made you some work it seems

Fighting the actions syntax took longer than expected 😅

mathause
mathause approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge? I am looking forward to testing this 😉

@keewis
Copy link
Contributor Author

keewis commented Nov 18, 2024

There's still a lot more to be done (mainly, tests for the other functions in the script), but for now I'll go ahead and merge. Feel free to test and open issues if anything fails.

@keewis keewis merged commit e0dd5e5 into xarray-contrib:main Nov 18, 2024
10 checks passed
@keewis keewis deleted the script branch November 18, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keewis @mathause