Add ASV benchmark CI workflow

[Illviljan]

Add an ASV workflow for easy benchmarking. Adapted from xarray.

[Illviljan]

@dcherian, could you add the run-benchmark label?

[dcherian]

You have a pending invite to xarray-contrib, if you accept I think you have rights to do that. (I'd like to make sure you can do it so not doing it right now)

[Illviljan]

Thanks, it works!

[Illviljan]

The workflow appears to work!

But the benchmark is probably broken?

 Error:                Traceback (most recent call last):
                 File "/home/runner/.local/lib/python3.8/site-packages/asv/benchmark.py", line 1293, in main_run_server
                   main_run(run_args)
                 File "/home/runner/.local/lib/python3.8/site-packages/asv/benchmark.py", line 1167, in main_run
                   result = benchmark.do_run()
                 File "/home/runner/.local/lib/python3.8/site-packages/asv/benchmark.py", line 573, in do_run
                   return self.run(*self._current_params)
                 File "/home/runner/.local/lib/python3.8/site-packages/asv/benchmark.py", line 669, in run
                   samples, number = self.benchmark_timing(timer, min_repeat, max_repeat,
                 File "/home/runner/.local/lib/python3.8/site-packages/asv/benchmark.py", line 705, in benchmark_timing
                   timing = timer.timeit(number)
                 File "/home/runner/work/flox/flox/asv_bench/.asv/env/b75ad52f6dea6a19ad824a655424eb23/lib/python3.9/timeit.py", line 177, in timeit
                   timing = self.inner(it, self.timer)
                 File "<timeit-src>", line 6, in inner
                 File "/home/runner/.local/lib/python3.8/site-packages/asv/benchmark.py", line 627, in <lambda>
                   func = lambda: self.func(*param)
                 File "/home/runner/work/flox/flox/asv_bench/benchmarks/combine.py", line 16, in time_combine
                   flox.core._npg_combine(
               AttributeError: module 'flox.core' has no attribute '_npg_combine'
               asv: benchmark failed (exit status 1)

Maybe we should merge this and make a new PR fixing the benchmarks?

[dcherian]

Could just fix it here.

Is it necessary to change these paths? If so, I think you need to also add a change deleting the existing file.

[Illviljan]

Do you see what needs to be changed? I'm not familiar enough with this code and I can't find something that resembles the old flox.core._npg_combine?

The paths were changed to align with xarray and I don't want to fiddle with the paths. I still have nightmares of getting the correct paths when adding this in xarray.

From what I can tell it seems to understand that it was moved or?

[dcherian]

I mean that the benchmarks folder has been moved but in the diff it doesn't show this. It looks like asv_bench/benchmarks/combine.py was added, but the earlier benchmarks/combine.py was not removed

[dcherian]

Could micromamba this like with the other workflows and get some caching.

[Illviljan]

I copied from the other worklows and it seems to be working? Does this make sense to you?

[dcherian]

Looks great. thanks @Illviljan feel free to merge when you're done.