This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Keep attrs in map_over_subtree
#279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
reviewed
Nov 20, 2023
datatree/mapping.py
Outdated
Comment on lines
214
to
217
| if node_of_first_tree.has_data | ||
| else node_of_first_tree.ds | ||
| if node_of_first_tree.has_attrs | ||
| else None |
There was a problem hiding this comment.
I did not even know that this double if else was valid python!
Could we perhaps rewrite this to be more intuitive, e.g.
if node.has_data:
result = func_with_error_context(...)
elif node.has_attrs:
# propagate attrs
result = node.ds
else:
# nothing to propagate so use fastpath to create empty node in new tree
result = NoneThere was a problem hiding this comment.
lol, neither did I. For some reason when I first looked at these lines I thought it was a list comprehension and had to have google remind me whether you can elif in a comprehension (you can not, but you can do this weird syntax 🤷 ). Fixed.
|
Thanks for the bug report and the fix @slevang ! |
Closed
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
* keep attrs in map_over_subtree * more intelligible logic --------- Co-authored-by: Tom Nicholas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesdocs/source/whats-new.rst