This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Method to match node paths via glob #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
TomNicholas
changed the title
TomNicholas
commented
Oct 24, 2023
TomNicholas
commented
Oct 24, 2023
datatree/datatree.py
Outdated
| Examples | ||
| -------- | ||
| >>> dt = DataTree.from_dict( | ||
| >>> { |
There was a problem hiding this comment.
@keewis blackdoc raised an error here:
error: cannot format /code/datatree/datatree.py: Cannot parse: 1217:0: EOF in multi-line statement
There was a problem hiding this comment.
that's not proper doctest, you need to use ... for continuation lines.
I guess blackdoc could be extended to detect this, but that would mean that it would have to parse python code itself (which it does not so far, and would make it a fair bit more complicated): it detects code blocks using the doctest syntax and then applies black to each of them separately.
There was a problem hiding this comment.
Oh - I copied this from syntax used in the docstring of xarray's Dataset.map. So I guess it should look like this example from pint-xarray. Thanks!
There was a problem hiding this comment.
Actually no I'm just being an idiot
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
* test * implementation * documentation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * whatsnew * API * correct faulty test * remove newline * search-> match * format continuation lines correctly --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesapi.rstdocs/source/whats-new.rst