Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grid_bounds_to_polygons #478
base: main
Are you sure you want to change the base?
Add grid_bounds_to_polygons #478
Changes from 10 commits
9c3c5b6
d26bf4a
0370b53
83f8349
8a6b79f
96a00d8
efd423d
53cc744
0db0b96
d33610e
c048410
98be7c1
1f7ceae
25d8224
459365c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 461 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L461
Check warning on line 465 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L463-L465
Check warning on line 467 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L467
Check warning on line 470 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L470
Check warning on line 475 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L472-L475
Check warning on line 478 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L477-L478
Check warning on line 483 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L480-L483
Check warning on line 487 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L485-L487
Check warning on line 489 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L489
Check warning on line 491 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L491
Check warning on line 496 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L495-L496
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the reason for this is that most geographic data is given in WGS84 which is -180...180 (I may be wrong here). So if you want to compare it to regional polygons it is probably a good idea to wrap the data. Still, it may be confusing to users.
Maybe this could be optional. However, I am not sure what a good name is (In regionmask I call it
wrap_lon
with the options180
(= what you do here),360
andFalse
. That works but there may be better names).Check warning on line 498 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L498
Check warning on line 501 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L501
Check warning on line 503 in cf_xarray/geometry.py
Codecov / codecov/patch
cf_xarray/geometry.py#L503