Avoid illegal instructions from nocrypto #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nocrypto detects CPU features at *build time*, instead of runtime. If the build machine is newer than the machine you install the binary on then it would crash with an illegal instruction on startup. See https://github.com/mirleft/ocaml-nocrypto#illegal-instructions and mirleft/ocaml-nocrypto#73 Since there is no runtime detection the only safe thing to do is to disable the use of these instructions always. For version 0.5.3 this is done with `--disable-modernity`, for 0.5.4 it'll be `NOCRYPTO_ACCELERATE=false` environment variable. Signed-off-by: Edwin Török <[email protected]>
gaborigloi
approved these changes
Nov 7, 2017
robhoes
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nocrypto detects CPU features at build time, instead of runtime.
If the build machine is newer than the machine you install the binary on then it
would crash with an illegal instruction on startup.
See https://github.com/mirleft/ocaml-nocrypto#illegal-instructions and mirleft/ocaml-nocrypto#73
Since there is no runtime detection the only safe thing to do is to disable the
use of these instructions always.
For version 0.5.3 this is done with
--disable-modernity, for 0.5.4 it'll beNOCRYPTO_ACCELERATE=falseenvironment variable.Tested with
opam reinstall -y nocrypto.0.5.3 -v: without this patch I see-maesin the build output, with this patch I do not. (note: you only see-maesif/proc/cpuinfohas theaesflag)