CP-51836: Restrict/check binary_url of remote_pool repository #6089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BengangY
force-pushed
the
private/bengangy/CP-51836
branch
from
a0f6b1c to
858767b
Compare
psafont
reviewed
Oct 29, 2024
BengangY
force-pushed
the
private/bengangy/CP-51836
branch
from
858767b to
10f9be8
Compare
lindig
approved these changes
Oct 30, 2024
gangj
reviewed
Oct 30, 2024
Vincent-lau
reviewed
Oct 30, 2024
BengangY
force-pushed
the
private/bengangy/CP-51836
branch
from
10f9be8 to
bafc672
Compare
gangj
reviewed
Oct 31, 2024
gangj
approved these changes
Oct 31, 2024
Add an assertion to restrict `binary_url` of remote_pool repository to be in the format of `https://<coordinator-ip>/repository/enabled`. Signed-off-by: Bengang Yuan <[email protected]>
Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CP-51836
branch
from
bafc672 to
645e98c
Compare
BengangY
merged commit d0f4517
into
xapi-project:feature/easier-pool-join
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary_urlof remote_pool repository to be in theformat of
https://<coordinator-ip>/repository/enabled.binary_urlof remote_pool repository.