-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xapi-idl: jbuilderize #174
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
fcc7337
Port to jbuilder
edwintorok e71f678
fix jbuild --dev warnings for unused values
edwintorok cb4d2a5
jbuild --dev: drop unused opens
edwintorok b80d419
jbuilder --dev: drop unused code
edwintorok 83e63b7
jbuilder --dev: fix printf format
edwintorok 82be0ac
jbuilder --dev: fix deprecated String usage
edwintorok 4b7922f
jbuilder --dev: fix warning on free
edwintorok 0e51b61
jbuilder --dev: fix typo in test
edwintorok 89afe85
jbuilder --dev: disable warnings for some pieces of code
edwintorok e7af869
Switch to non-deprecated Lwt_unix.Versioned.bind_2
edwintorok d28be23
jbuilder --dev: fix ambiguos doc comment
edwintorok d9c3009
jbuilder: xapi-idl vs xcp
edwintorok 9fad115
Add .coverage.sh
edwintorok ad4c135
Add bisect_ppx preprocessing
edwintorok 254f58e
Disable deprecation warning on String.lowercase
edwintorok 75d2189
fixup! Disable deprecation warning on String.lowercase
edwintorok f231e9b
drop unused D module
edwintorok 933d514
Reformat jbuild files
edwintorok ebe9f3f
sort opam dependencies
edwintorok f14bc49
Move from deprecated Stdext to more specific Xapi-stdext-* modules
edwintorok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| opam-version: "1.2" | ||
| authors: "Dave Scott" | ||
| homepage: "https://github.com/xapi-project/xcp-idl" | ||
| bug-reports: "https://github.com/xapi-project/xcp-idl/issues" | ||
| dev-repo: "git://github.com/xapi-project/xcp-idl" | ||
| maintainer: "[email protected]" | ||
| tags: [ "org:xapi-project" ] | ||
| depends: [ "xcp" ] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a similar thing for
stdextand I already start regretting it... Should we instead update all the package references and usexapi-idlonce and for all? For therrd-stuff port I decided to go and update all the packages, it's annoing and invasive but it's a cleanup afterall. I'd like to know @robhoes and @lindig point of view as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been giving a few thoughts about this. I think for the time being, for libraries like this or stdext that are pervasive across the whole product, we should value backward compatibility over coherence. After we are done with the ports, we can go an kill the backward compatibility hacks all at once.