xapi-idl: jbuilderize #174
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| #!/bin/sh | ||
|
|
||
| set -ex | ||
|
|
||
| COVERAGE_DIR=.coverage | ||
| rm -rf $COVERAGE_DIR | ||
| mkdir -p $COVERAGE_DIR | ||
| pushd $COVERAGE_DIR | ||
| if [ -z "$KEEP" ]; then trap "popd; rm -rf $COVERAGE_DIR" EXIT; fi | ||
|
|
||
| $(which cp) -r ../* . | ||
|
|
||
| opam install bisect_ppx ocveralls -y | ||
|
|
||
| export BISECT_ENABLE=YES | ||
| jbuilder runtest | ||
|
|
||
| outs=$(find . | grep bisect.*.out) | ||
| bisect-ppx-report -I $(dirname $outs[1]) -text report $outs | ||
| bisect-ppx-report -I $(dirname $outs[1]) -summary-only -text summary $outs | ||
| if [ -n "$HTML" ]; then bisect-ppx-report -I $(dirname $outs[1]) -html ../html-report $outs; fi | ||
|
|
||
| if [ -n "$TRAVIS" ]; then | ||
| echo "\$TRAVIS set; running ocveralls and sending to coveralls.io..." | ||
| ocveralls --prefix _build/default $outs --send | ||
| else | ||
| echo "\$TRAVIS not set; displaying results of bisect-report..." | ||
| cat report | ||
| cat summary | ||
| fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,5 @@ | ||
| *.merlin | ||
| *.install | ||
| *.swp | ||
|
|
||
| _build | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,29 @@ | ||
| .PHONY: build release install uninstall clean test doc reindent | ||
|
|
||
| build: | ||
| jbuilder build @install --dev -j $$(getconf _NPROCESSORS_ONLN) | ||
|
|
||
| release: | ||
| jbuilder build @install | ||
|
|
||
| install: | ||
| jbuilder install | ||
|
|
||
| uninstall: | ||
| jbuilder uninstall | ||
|
|
||
| clean: | ||
| jbuilder clean | ||
|
|
||
| test: | ||
| jbuilder runtest --dev -j $$(getconf _NPROCESSORS_ONLN) | ||
|
|
||
| # requires odoc | ||
| doc: | ||
| jbuilder build @doc | ||
|
|
||
| gh-pages: | ||
| bash .docgen.sh | ||
|
|
||
| reindent: | ||
| git ls-files '*.ml' '*.mli' | xargs ocp-indent --syntax cstruct -i | ||
|
There was a problem hiding this comment. I am going to update the internal documentation using this: it's much cleaner than our default |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a similar thing for
stdextand I already start regretting it... Should we instead update all the package references and usexapi-idlonce and for all? For therrd-stuff port I decided to go and update all the packages, it's annoing and invasive but it's a cleanup afterall. I'd like to know @robhoes and @lindig point of view as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been giving a few thoughts about this. I think for the time being, for libraries like this or stdext that are pervasive across the whole product, we should value backward compatibility over coherence. After we are done with the ports, we can go an kill the backward compatibility hacks all at once.