Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA-142451: Failed to report all LUNs advertised on targets sharing the same IQN #210

Closed
wants to merge 1 commit into from
Closed

CA-142451: Failed to report all LUNs advertised on targets sharing the same IQN #210

wants to merge 1 commit into from

Conversation

siddharthv
Copy link
Contributor

Port from master to xs64bit

@germanop @siddharthv
CA-142451: Failed to report all LUNs advertised on targets sharing th…
ea1d91b 
…e same IQN

If a multicontroller array advertises its targets using the same IQN
but different IPs and the LUNs in those targets are distinct,
we are able to show only LUNs coming from the first IP address.

The fix reinstates a line that was removed in commit 391bdf055dff
in our old sm.hg repository.
The purporse of the line is to first check that we have
a valid active iscsi connection using the original pair IP,IQN.
Only if it fails (it should not in my opinion) we fall back to
other ip addresses.

Signed-off-by: Germano Percossi <[email protected]>
Reviewed-by: Chandrika Srinivasan <[email protected]>
Imported-by: Siddharth Vinothkumar <[email protected]>

GitHub: closes xapi-project#207 on xapi-project/sm
(cherry picked from commit 66c89ea)
@matelakat
Copy link
Contributor

@siddharthv - could you try to cover it with unit tests according to my original comment: #207 (comment)
or is this exercise on me again?

@fquesnel fquesnel mentioned this pull request Aug 20, 2014
Closed
@matelakat matelakat mentioned this pull request Aug 22, 2014
Closed
@germanop
Copy link
Contributor

The commit message tags are wrong.

  • The Github tag must be replaced with the right one (in this case it is 210).
  • The Github tag is always the last tag
  • It does not matter if we use imported-by or signed-off-by as long as they come right after
    the cherry picked message (in this case the signed-off-by is clearly meaning who imported)
  • The original CA ticket was meant to be just a placeholder for the defect. Fixes for creedence
    and clearwater are treated as subtasks of this defect. In this case I created CA-144709 for
    the merge in creedence. The original CA ticket is untouched because is part of the original
    commit message but the latter CA ticket needs to be used as the reason for the import.

Because we never agreed on a format, for the time begin refer to 2b2738e as a template
for the import commit message

@matelakat
Copy link
Contributor

@germanop - thanks for the comments, closing it down, and will address your issues in #213

@matelakat matelakat closed this Aug 28, 2014
@germanop germanop mentioned this pull request Aug 29, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddharthv @matelakat @germanop