Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add support for optional socials #15

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[Feature] Add support for optional socials #15

merged 1 commit into from
Oct 31, 2024

Conversation

xames3
Copy link
Owner

@xames3 xames3 commented Oct 31, 2024

Description of the change:

  • This brings the support for adding various new social media connections like LinkedIn, ORCID, Twitter and YouTube to the modal pop-up.
  • This change also fixes the issue with rendering images over URL. With this change, the images need not be necessarily stored on the device and can be parsed directly over the internet.

References:

@xames3
feat: add support for optional socials
a3dfba9 
Description of the change:
    - This brings the support for adding various new social media
      connections like LinkedIn, ORCID, Twitter and YouTube to the modal
      pop-up.
    - This change also fixes the issue with rendering images over URL.
      With this change, the images need not be necessarily stored on the
      device and can be parsed directly over the internet.

References:
  - #13 (GitHub issue)

Signed-off-by: Akshay Mestry <[email protected]>
@xames3 xames3 added breaking change pull requests that alter the project in a way that is not backward-compatible documentation updates, additions, or improvements to the project’s documentation duplicate this issue or pull request already exists enhancement enhancements to existing functionality or the addition of new features high priority pull requests that should be reviewed and merged as a priority due to their importance miscellaneous miscellaneous changes and some of the general inner workings needs testing pull requests that need to be tested or validated before they can be merged ready for review pull requests that are finished and awaiting review by the team or community work in progress pull requests that are not yet ready for review or merging labels Oct 31, 2024
@xames3 xames3 self-assigned this Oct 31, 2024
@xames3 xames3 merged commit c28cfe8 into feature-release-mk-ii Oct 31, 2024
@xames3 xames3 deleted the fix-contributors-modal branch October 31, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xames3 xames3

Labels
breaking change pull requests that alter the project in a way that is not backward-compatible documentation updates, additions, or improvements to the project’s documentation duplicate this issue or pull request already exists enhancement enhancements to existing functionality or the addition of new features high priority pull requests that should be reviewed and merged as a priority due to their importance miscellaneous miscellaneous changes and some of the general inner workings needs testing pull requests that need to be tested or validated before they can be merged ready for review pull requests that are finished and awaiting review by the team or community work in progress pull requests that are not yet ready for review or merging
Projects
Open-Source Projects Kanban Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xames3