Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Need to add contributor modal instead of mailto #11

Closed
xames3 opened this issue Sep 12, 2024 · 2 comments · Fixed by #13
Closed

[Feature] Need to add contributor modal instead of mailto #11

xames3 opened this issue Sep 12, 2024 · 2 comments · Fixed by #13
Assignees
@xames3
Labels
approved pull requests that have passed review and are cleared for merging awaiting changes pull requests that need updates or corrections based on feedback discussion needed pull requests that need community or team input before moving forwardz documentation updates, additions, or improvements to the project’s documentation enhancement enhancements to existing functionality or the addition of new features help wanted extra attention is needed and appreciate some help low priority pull requests that are less critical and can wait if necessary miscellaneous miscellaneous changes and some of the general inner workings question further information is requested by the team members or community work in progress pull requests that are not yet ready for review or merging

Comments

@xames3
Copy link
Owner

xames3 commented Sep 12, 2024

  • need to add a proper modal pop-up for contributors. the modal should be able to show the below details:
    • the pop-up should show the name of the contributor.
    • the pop-up should be able to show the email and contact information provided by the contributor.
    • the pop-up should be able to show/fetch information about the contributor from a source file (database or just a reference file).
    • the pop-up should be able to show the contributor's ORCID if possible.

these are tentative features as of now. they can be worked upon in the near future, but these would be some basic requirements.
@xames3 xames3 added awaiting changes pull requests that need updates or corrections based on feedback discussion needed pull requests that need community or team input before moving forwardz documentation updates, additions, or improvements to the project’s documentation enhancement enhancements to existing functionality or the addition of new features help wanted extra attention is needed and appreciate some help low priority pull requests that are less critical and can wait if necessary miscellaneous miscellaneous changes and some of the general inner workings question further information is requested by the team members or community labels Sep 12, 2024
@xames3 xames3 self-assigned this Sep 12, 2024
@xames3 xames3 mentioned this issue Oct 25, 2024
Closed
9 tasks
@xames3 xames3 changed the title Need to add contributor modal instead of mailto [Feature] Need to add contributor modal instead of mailto Oct 25, 2024
@xames3 xames3 mentioned this issue Oct 30, 2024
Merged
@xames3
Copy link
Owner Author

xames3 commented Oct 31, 2024 •
edited
Loading

  • most of the required feature-set is finished. however, still some more work needs to be done.

  • currently, the user's profile photo is shown but there is no support for a default photo when nothing seems to be available. this seems like a step-back from what the feature should be offering.

  • currently, there is no support for URL-parsed images. this is something that needs to be worked up on at the earliest. based on the current understanding, below should be the tasks list:

    • add support for default photo with proper setup of images directory under _build/build.
    • add support for parsing images based on URLs.
    • add support for parsing optional ORCID.
    • add support for dynamic scaling of user's reachability options based on different socials provided by the user.

@xames3 xames3 added work in progress pull requests that are not yet ready for review or merging approved pull requests that have passed review and are cleared for merging labels Oct 31, 2024
@xames3
Copy link
Owner Author

xames3 commented Oct 31, 2024

  • the implementation seems good for now. this issue can be marked as resolved.

@xames3 xames3 closed this as completed Oct 31, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open-Source Projects Kanban Board Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xames3 xames3

Labels
approved pull requests that have passed review and are cleared for merging awaiting changes pull requests that need updates or corrections based on feedback discussion needed pull requests that need community or team input before moving forwardz documentation updates, additions, or improvements to the project’s documentation enhancement enhancements to existing functionality or the addition of new features help wanted extra attention is needed and appreciate some help low priority pull requests that are less critical and can wait if necessary miscellaneous miscellaneous changes and some of the general inner workings question further information is requested by the team members or community work in progress pull requests that are not yet ready for review or merging
Projects
Open-Source Projects Kanban Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature Release Mk-II xames3/coeus-sphinx-theme
1 participant
@xames3