[msbuild] Have XcodeCompilerToolTask use xcrun to start Apple tools (#9965)
#9972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls (xamarin#9965) 1. Use `xcrun` to run `ibtool` (and `actool`) and avoid toolchain mismatches 2. Set `DEVELOPER_DIR` so everyone (well `xcrun`) use the same toolchain 3. Workaround for `macos-arm64` issue (FB8827920) * Start `ibtool` as an `Apple` [Silicon] process * This will ensure the `ibtoold` daemon is also running as `Apple` * If `ibtoold` is run as `Intel` then `ibtool` asserts and build fail ``` LaunchScreen.storyboard : error : 2020-10-26 14:24:52.757 ibtoold[37142:6681382] [MT] DVTAssertions: Warning in /Library/Caches/com.apple.xbs/Sources/IDEInterfaceBuilder/IDEInterfaceBuilder-17506/InterfaceBuilderKit/Utilities/IBAbstractInterfaceBuilderPlatformToolManager.m:481 LaunchScreen.storyboard : error : Details: Failed to attach to IBAgent-iOS with error: Error Domain=com.apple.InterfaceBuilder Code=-1 "Encountered an error communicating with IBAgent-iOS." UserInfo={NSLocalizedFailureReason=IBAgent-iOS (37146) failed to launch and exited with status 10, NSUnderlyingError=0x7fa4e58fc760 {Error Domain=com.apple.InterfaceBuilder Code=-1 "Failed to launch IBAgent-iOS via CoreSimulator spawn" UserInfo={NSLocalizedDescription=Failed to launch IBAgent-iOS via CoreSimulator spawn, NSUnderlyingError=0x7fa4e5e8a900 {Error Domain=com.apple.InterfaceBuilder Code=-1 "Failed to handshake with platform tool" UserInfo={NSLocalizedFailureReason=Failed to open connection over FIFOs with platform tool, NSLocalizedDescription=Failed to handshake with platform tool, NSUnderlyingError=0x7fa4e5e237c0 {Error Domain=com.apple.InterfaceBuilder Code=-1 "" UserInfo=0x7fa4e5e8bba0 (not displayed)}}}}}, NSLocalizedRecoverySuggestion=Please check Console.app for crash reports for "IBAgent-iOS" for further information., NSLocalizedDescription=Encountered an error communicating with IBAgent-iOS.} LaunchScreen.storyboard : error : Object: <IBCocoaTouchToolManager> LaunchScreen.storyboard : error : Method: +_THREADSAFE_launchNewToolWithLaunchContext:executionContext:toolProxyClass:proxyDelegate:failureContext:requestingMethod:error:forReason: LaunchScreen.storyboard : error : Thread: <NSThread: 0x7fa4e341af70>{number = 1, name = main} LaunchScreen.storyboard : error : Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide. LaunchScreen.storyboard : error : 2020-10-26 14:24:52.766 ibtoold[37142:6681382] [MT] IBPlatformTool: *** Failed to launch tool with description <IBCocoaTouchPlatformToolDescription: 0x7fa4e5f34160> System content for IBCocoaTouchFramework-fourteenAndLater <IBScaleFactorDeviceTypeDescription: 0x7fa4e5f2fb50> scaleFactor=2x, renderMode.identifier=(null): Encountered an error communicating with IBAgent-iOS. (Failure reason: IBAgent-iOS (37146) failed to launch and exited with status 10): Failed to launch IBAgent-iOS via CoreSimulator spawn: Failed to handshake with platform tool (Failure reason: Failed to open connection over FIFOs with platform tool): : Failed to open FIFOs for handshaking with platform tool (Failure reason: IBAgent-iOS exited before we could handshake) /Library/Frameworks/Mono.framework/External/xbuild/Xamarin/iOS/Xamarin.iOS.Common.targets(1425,3): error : ibtool exited with code 1 /Library/Frameworks/Mono.framework/External/xbuild/Xamarin/iOS/Xamarin.iOS.Common.targets(1425,3): error : LaunchScreen.storyboard : ibtool error : Encountered an error communicating with IBAgent-iOS. ``` Note: `main` has diverged quite a bit (net6 support) so this pull request will need to be re-worked (it won't apply) Fixes xamarin#4634 Foreport of xamarin#9965 since the source code diverged from `xcode12.2`
tj-devel709
reviewed
Oct 27, 2020
| @@ -711,15 +712,15 @@ public void BuildingSameSolutionTwice_ShouldNotRunACToolTwice () | |||
| string project = TI.GenerateUnifiedExecutableProject (test); | |||
|
|
|||
| string buildOutput = TI.BuildProject (project); | |||
| Assert.True (buildOutput.Contains ("actool execution started with arguments"), $"Initial build should run actool"); | |||
| Assert.True (buildOutput.Contains (actool), $"Initial build should run actool"); | |||
There was a problem hiding this comment.
Just curious if there is a reason to use the $ before the string if we do not use any variables inside it?
There was a problem hiding this comment.
no, I did not notice it in the original source (or I would have removed it).
rolfbjarne
approved these changes
Oct 27, 2020
|
Build failure Test results48 tests failed, 19 tests passed.Failed tests
|
dalexsoto
approved these changes
Oct 27, 2020
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
xcrunto runibtool(andactool) and avoid toolchain mismatchesSet
DEVELOPER_DIRso everyone (wellxcrun) use the same toolchainWorkaround for
macos-arm64issue (FB8827920)ibtoolas anApple[Silicon] processibtoolddaemon is also running asAppleibtooldis run asIntelthenibtoolasserts and build failNote:
mainhas diverged quite a bit (net6 support) so this pull requestwill need to be re-worked (it won't apply)
Fixes #4634
Foreport of #9965 since the source code diverged from
xcode12.2