Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Remove workaround for mono/linker#1304, which has now been fixed. #9862

Merged
merged 2 commits into from
Jan 18, 2021
Merged

[dotnet] Remove workaround for mono/linker#1304, which has now been fixed. #9862

merged 2 commits into from
Jan 18, 2021

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Oct 14, 2020 •
edited
Loading

Contributes to #8901.

@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Oct 14, 2020
@rolfbjarne rolfbjarne mentioned this pull request Oct 14, 2020
Closed
61 tasks
@monojenkins
Copy link
Collaborator

Build failure
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 62 tests passed.

Failed tests

  • link all/iOS Unified 64-bits - simulator/Debug [dotnet]: Failed
  • link all/iOS Unified 64-bits - simulator/Release [dotnet]: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations) [dotnet]: Failed

@rolfbjarne
Copy link
Member Author

This ran into a linker bug: dotnet/linker#1576, and is blocked on that bug.

@rolfbjarne rolfbjarne added the do-not-merge Do not merge this pull request label Oct 20, 2020
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ Tests failed on Build ❌

Tests failed on Build.

Test results

1 tests failed, 40 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

Pipeline on Agent XAMBOT-1103

@rolfbjarne
Copy link
Member Author

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2154)

@rolfbjarne rolfbjarne removed the do-not-merge Do not merge this pull request label Jan 18, 2021
@rolfbjarne rolfbjarne merged commit aa67191 into xamarin:main Jan 18, 2021
@rolfbjarne rolfbjarne deleted the dotnet-remove-workaround-linker-1304 branch January 18, 2021 07:21
@rolfbjarne rolfbjarne mentioned this pull request Sep 8, 2021
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@chamons chamons chamons approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rolfbjarne @monojenkins @vs-mobiletools-engineering-service2 @spouliot @mandel-macaque @chamons @tj-devel709 @whitneyschmidt