[Harness] Create IBuildToolTask and use it in the RunTestTask. #8375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the RunTestTask. The initial idea of the refactoring looked nice but as soon as we want to get the RunTestTask out of jenkins, we have a number of naming issues. Move the tools to not use the *Task postfix so that it is cleaner and we can later extra the RunTestTask better.
In order to de-couple the RunTestTask from Jenkins, create an interface to be implemented, which is pass to use as a member (Composition pattern). In order to do that, do not expose Jenkins as a property of the interface because it is required just by the base constructor. Moving the the use an interfance meant a lot of small changes that should have no real effect (the compiler should have caught any possible issues).
mandel-macaque
added
the
run-internal-tests
|
Created as a draft pr so that the review is simpler. |
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Install Provisioning Profiles' 🔥 : hudson.AbortException: script returned exit code 104 ✅ Build succeeded |
|
Build success |
rolfbjarne
approved these changes
Apr 14, 2020
premun
approved these changes
Apr 14, 2020
mandel-macaque
changed the base branch from
rename-tests-tasks-to-avoid-overlap
to
master
|
Build failure |
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Install Provisioning Profiles' 🔥 : hudson.AbortException: script returned exit code 104 ✅ Build succeeded |
|
Build success |
mandel-macaque
added a commit
that referenced
this pull request
Aug 5, 2020
In order to de-couple the RunTestTask from Jenkins, create an interface to be implemented, which is pass to use as a member (Composition pattern). In order to do that, do not expose Jenkins as a property of the interface because it is required just by the base constructor. Moving the the use an interface meant a lot of small changes that should have no real effect (the compiler should have caught any possible issues).
mandel-macaque
added a commit
that referenced
this pull request
Oct 12, 2020
In order to de-couple the RunTestTask from Jenkins, create an interface to be implemented, which is pass to use as a member (Composition pattern). In order to do that, do not expose Jenkins as a property of the interface because it is required just by the base constructor. Moving the the use an interface meant a lot of small changes that should have no real effect (the compiler should have caught any possible issues).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to de-couple the RunTestTask from Jenkins, create an interface
to be implemented, which is pass to use as a member (Composition
pattern). In order to do that, do not expose Jenkins as a property of
the interface because it is required just by the base constructor.
Moving the the use an interfance meant a lot of small changes that
should have no real effect (the compiler should have caught any possible
issues).