Setting an environment variable to null doesn't work in .netcore. #8316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a difference between mono and .netcore with regards to environment
variables when launching processes.
For the following example:
process.StartInfo.EnvironmentVariables ["FOO"] = null;
.netcore will launch the process with an empty FOO variable, while mono will
launch the process with no FOO variable set.
So unstead remove the variable from the collection of environment variables
(this works fine even if the collection doesn't contain the variable).
Ref: dotnet/runtime#34446
This comment has been minimized.
This comment has been minimized.
|
Build success |
spouliot
approved these changes
Apr 8, 2020
mandel-macaque
approved these changes
Apr 8, 2020
mandel-macaque
pushed a commit
that referenced
this pull request
Oct 12, 2020
) There is a difference between mono and .netcore with regards to environment variables when launching processes. For the following example: process.StartInfo.EnvironmentVariables ["FOO"] = null; .netcore will launch the process with an empty FOO variable, while mono will launch the process with no FOO variable set. So unstead remove the variable from the collection of environment variables (this works fine even if the collection doesn't contain the variable). Ref: dotnet/runtime#34446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a difference between mono and .netcore with regards to environment
variables when launching processes.
For the following example:
.netcore will launch the process with an empty FOO variable, while mono will
launch the process with no FOO variable set.
So unstead remove the variable from the collection of environment variables
(this works fine even if the collection doesn't contain the variable).
Ref: dotnet/runtime#34446