[msbuild] Compute the ComputedFrameworkMoniker later in the build. Fixes #8277. #8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xamarin#8277. It might only be necessary for Xamarin.iOS builds, but modify both XI and XM so that the logic is identical. Fixes xamarin#8277.
rolfbjarne
requested review from
chamons,
emaf,
jstedfast,
kzu and
VincentDondain
as code owners
Therzok
approved these changes
Apr 3, 2020
spouliot
approved these changes
Apr 3, 2020
mandel-macaque
approved these changes
Apr 3, 2020
|
Build failure Test results42 tests failed, 45 tests passed.Failed tests
|
stephen-hawley
approved these changes
Apr 3, 2020
emaf
approved these changes
Apr 3, 2020
dalexsoto
approved these changes
Apr 3, 2020
…ops like the mac version.
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might only be necessary for Xamarin.iOS builds, but modify both XI and XM
so that the logic is identical.
Fixes #8277.