[d16-5-xcode11.4] Wrap mono_gc_init_finalizer_thread() call with now-needed coop GC state transition #8248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te transition. Starting with mono/mono#16907 , the Mono runtime ends in GC-Safe state (mode) after mono_jit_init_version() is called. The monotouch code did not expect that, and calls mono_gc_init_finalizer_thread() which also tries to enter GC-safe mode. Should fix mono/mono#19372
dalexsoto
approved these changes
Mar 31, 2020
dalexsoto
added
the
build-package
mandel-macaque
approved these changes
Mar 31, 2020
spouliot
approved these changes
Mar 31, 2020
|
Build failure Test results1 tests failed, 86 tests passed.Failed tests
|
rolfbjarne
approved these changes
Mar 31, 2020
|
Known failure: HE0038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix mono/mono#19372
Backport of #8242.
/cc @dalexsoto @alexischr