[Harness] Make CrashSnapshotReporter injectable and add unit tests

tests/xharness/AppRunner.cs

@@ -55,6 +55,7 @@ class AppRunner
 		readonly ISimulatorsLoaderFactory simulatorsLoaderFactory;
 		readonly ISimpleListenerFactory listenerFactory;
 		readonly IDeviceLoaderFactory devicesLoaderFactory;
+		readonly ICrashSnapshotReporterFactory snapshotReporterFactory;
 
 		readonly RunMode mode;
 		readonly bool isSimulator;
@@ -95,6 +96,7 @@ public AppRunner (IProcessManager processManager,
 						  ISimulatorsLoaderFactory simulatorsFactory,
 						  ISimpleListenerFactory simpleListenerFactory,
 						  IDeviceLoaderFactory devicesFactory,
+						  ICrashSnapshotReporterFactory snapshotReporterFactory,
 						  AppRunnerTarget target,
 						  IHarness harness,
 						  ILog mainLog,
@@ -113,6 +115,7 @@ public AppRunner (IProcessManager processManager,
 			this.simulatorsLoaderFactory = simulatorsFactory ?? throw new ArgumentNullException (nameof (simulatorsFactory));
 			this.listenerFactory = simpleListenerFactory ?? throw new ArgumentNullException (nameof (simpleListenerFactory));
 			this.devicesLoaderFactory = devicesFactory ?? throw new ArgumentNullException (nameof (devicesFactory));
+			this.snapshotReporterFactory = snapshotReporterFactory ?? throw new ArgumentNullException (nameof (snapshotReporterFactory));
 			this.harness = harness ?? throw new ArgumentNullException (nameof (harness));
 			this.MainLog = mainLog ?? throw new ArgumentNullException (nameof (mainLog));
 			this.projectFilePath = projectFilePath ?? throw new ArgumentNullException (nameof (projectFilePath));
@@ -423,15 +426,14 @@ public bool TestsSucceeded (AppInformation appInfo, string test_log_path, bool t
 
 		public async Task<int> RunAsync ()
 		{
-			CrashReportSnapshot crash_reports;
 			ILog device_system_log = null;
 			ILog listener_log = null;
 			ILog run_log = MainLog;
 
 			if (!isSimulator)
 				FindDevice ();
 
-			crash_reports = new CrashReportSnapshot (harness, MainLog, Logs, isDevice: !isSimulator, deviceName);
+			ICrashSnapshotReporter crash_reports = snapshotReporterFactory.Create (MainLog, Logs, isDevice: !isSimulator, deviceName);
 
 			var args = new List<string> ();
 			if (!string.IsNullOrEmpty (harness.XcodeRoot)) {
@@ -747,7 +749,7 @@ public async Task<int> RunAsync ()
 			if (!success.Value) {
 				int pid = 0;
 				string crash_reason = null;
-				foreach (var crash in crash_reports.Logs) {
+				foreach (var crash in Logs) {
 					try {
 						if (pid == 0) {
 							// Find the pid
@@ -789,7 +791,7 @@ public async Task<int> RunAsync ()
 									variation,
 									$"App Crash {AppInformation.AppName} {variation}",
 									$"App crashed {crash_reason}.",
-									crash_reports.Log.FullPath,
+									MainLog.FullPath,
 									harness.XmlJargon);
 							}
 
@@ -813,7 +815,7 @@ public async Task<int> RunAsync ()
 							variation,
 							$"App Crash {AppInformation.AppName} {variation}",
 							$"App crashed: {FailureMessage}",
-							crash_reports.Log.FullPath,
+							MainLog.FullPath,
 							harness.XmlJargon);
 					}
 				} else if (launch_failure) {