Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mtouch/mmp] Rework how we find developer tools. Partial fix for #4634 and fixes #8005. (#8121) #8128

Merged
merged 2 commits into from
Mar 18, 2020
Merged

[mtouch/mmp] Rework how we find developer tools. Partial fix for #4634 and fixes #8005. (#8121) #8128

merged 2 commits into from
Mar 18, 2020

Conversation

rolfbjarne
Copy link
Member

Partial fix for #4634.
Fixes #8005.

@rolfbjarne rolfbjarne added build-package Build (and create package) on internal Jenkins. Apply 'run-internal-tests' to run tests too. run-sample-tests Run the sample tests skip-public-jenkins Completely skip execution in the public Jenkins instance labels Mar 17, 2020
@monojenkins
Copy link
Collaborator

Build success
ℹ️ Skipped execution

dalexsoto
dalexsoto approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rolf 👍

@xamarin-release-manager

This comment has been minimized.

Sign in to view
@spouliot spouliot added this to the xcode11.4 milestone Mar 17, 2020
ghost
ghost reviewed Mar 17, 2020
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: Ignore my previous comment.

@monojenkins
Copy link
Collaborator

Build success
ℹ️ Skipped execution

@xamarin-release-manager
Copy link
Collaborator

✅ Jenkins job (on internal Jenkins) succeeded

✅ Build succeeded
✅ Packages:

✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
ℹ️ Test run skipped: Not running tests here because they're run on public Jenkins.

@rolfbjarne rolfbjarne added skip-device-tests Skip device tests not-notes-worthy Ignore for release notes labels Mar 18, 2020
@spouliot
Copy link
Contributor

we started to have bug reports about the error
so we should remove not-notes-worthy to make the issue trackable in release notes

@rolfbjarne rolfbjarne added bug If an issue is a bug or a pull request a bug fix and removed not-notes-worthy Ignore for release notes labels Mar 18, 2020
@rolfbjarne rolfbjarne merged commit e9a0741 into d16-5-xcode11.4-samples Mar 18, 2020
@dalexsoto dalexsoto mentioned this pull request Mar 18, 2020
Merged
dalexsoto pushed a commit that referenced this pull request Mar 18, 2020
@rolfbjarne @dalexsoto
[mtouch/mmp] Rework how we find developer tools. Partial fix for #4634 …
bacd958 
…and fixes #8005. (#8121) (#8128)

Partial fix for #4634.
Fixes #8005.
@rolfbjarne rolfbjarne deleted the lipo-where-are-you-xcode11.4 branch May 5, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@chamons chamons Awaiting requested review from chamons

Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix build-package Build (and create package) on internal Jenkins. Apply 'run-internal-tests' to run tests too. run-sample-tests Run the sample tests skip-device-tests Skip device tests skip-public-jenkins Completely skip execution in the public Jenkins instance
Projects
None yet
Milestone
xcode11.4
Development

Successfully merging this pull request may close these issues.
6 participants
@rolfbjarne @monojenkins @xamarin-release-manager @spouliot @dalexsoto @mandel-macaque