[mtouch/mmp] Rework how we find developer tools. Partial fix for #4634 and fixes #8005. #8121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfbjarne
changed the title
spouliot
suggested changes
Mar 16, 2020
tools/common/Driver.cs
Outdated
|
|
||
| public static void RunStrip (IList<string> options) | ||
| { | ||
| RunXcodeTool ("strup", options); |
| if (!string.IsNullOrEmpty (DeveloperDirectory)) { | ||
| env.Add ("DEVELOPER_DIR"); | ||
| env.Add (DeveloperDirectory); | ||
| } |
There was a problem hiding this comment.
^ does the above change ? or can it be cached and reused
There was a problem hiding this comment.
You mean cache the list of environment values? Not sure if that will make much of a difference, because we cache the result from this function.
There was a problem hiding this comment.
It's more for consistency across invocations than time savings. If we believe it can change then the caching is not really correct. If it can't change then it does not need to be repeated for every tool being queried. Current code makes it ambiguous (but it's not a big thing)
mandel-macaque
approved these changes
Mar 16, 2020
|
Build failure |
dalexsoto
approved these changes
Mar 16, 2020
spouliot
approved these changes
Mar 16, 2020
|
Build failure Test results47 tests failed, 43 tests passed.Failed tests
|
|
build |
|
Build failure Test results5 tests failed, 85 tests passed.Failed tests
|
|
Build failure Test results1 tests failed, 89 tests passed.Failed tests
|
|
Test failure is due to https://github.com/xamarin/maccore/issues/2177. |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 17, 2020
…et#4634 and fixes dotnet#8005. (dotnet#8121) Partial fix for dotnet#4634. Fixes dotnet#8005.
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 17, 2020
…et#4634 and fixes dotnet#8005. (dotnet#8121) Partial fix for dotnet#4634. Fixes dotnet#8005.
rolfbjarne
added a commit
that referenced
this pull request
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #4634.
Fixes #8005.