Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserNotifications] Rename method to have a verb. #784

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/usernotifications.cs
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@ interface UNTextInputNotificationResponse {
[DisableDefaultCtor] // as per docs
interface UNNotificationServiceExtension {

// Not async because app developers are supposed to implement/override this method, not call it themselves.
[Export ("didReceiveNotificationRequest:withContentHandler:")]
void DidReceiveNotificationRequest (UNNotificationRequest request, Action<UNNotificationContent> contentHandler);

Expand Down Expand Up @@ -521,15 +522,15 @@ interface UNPushNotificationTrigger {
[Introduced (PlatformName.TvOS, 10, 0)]
[Introduced (PlatformName.WatchOS, 3, 0)]
[BaseType (typeof (UNNotificationTrigger))]
[DisableDefaultCtor] // as per doc, use supplied method (Trigger)
[DisableDefaultCtor] // as per doc, use supplied method (CreateTrigger)
interface UNTimeIntervalNotificationTrigger {

[Export ("timeInterval")]
double TimeInterval { get; }

[Static]
[Export ("triggerWithTimeInterval:repeats:")]
UNTimeIntervalNotificationTrigger Trigger (double timeInterval, bool repeats);
UNTimeIntervalNotificationTrigger CreateTrigger (double timeInterval, bool repeats);

[NullAllowed, Export ("nextTriggerDate")]
NSDate NextTriggerDate { get; }
Expand All @@ -538,7 +539,7 @@ interface UNTimeIntervalNotificationTrigger {
[Introduced (PlatformName.iOS, 10, 0)]
[Introduced (PlatformName.TvOS, 10, 0)]
[Introduced (PlatformName.WatchOS, 3, 0)]
[DisableDefaultCtor] // as per doc, use supplied method (Trigger)
[DisableDefaultCtor] // as per doc, use supplied method (CreateTrigger)
[BaseType (typeof (UNNotificationTrigger))]
interface UNCalendarNotificationTrigger {

Expand All @@ -547,7 +548,7 @@ interface UNCalendarNotificationTrigger {

[Static]
[Export ("triggerWithDateMatchingComponents:repeats:")]
UNCalendarNotificationTrigger Trigger (NSDateComponents dateComponents, bool repeats);
UNCalendarNotificationTrigger CreateTrigger (NSDateComponents dateComponents, bool repeats);

[NullAllowed, Export ("nextTriggerDate")]
NSDate NextTriggerDate { get; }
Expand All @@ -557,7 +558,7 @@ interface UNCalendarNotificationTrigger {
[Introduced (PlatformName.WatchOS, 3, 0)]
[Unavailable (PlatformName.TvOS)]
[BaseType (typeof (UNNotificationTrigger))]
[DisableDefaultCtor] // as per doc, use supplied method (Trigger)
[DisableDefaultCtor] // as per doc, use supplied method (CreateTrigger)
interface UNLocationNotificationTrigger {

[Export ("region", ArgumentSemantic.Copy)]
Expand All @@ -566,7 +567,7 @@ interface UNLocationNotificationTrigger {
[Unavailable (PlatformName.WatchOS)]
[Static]
[Export ("triggerWithRegion:repeats:")]
UNLocationNotificationTrigger Trigger (CLRegion region, bool repeats);
UNLocationNotificationTrigger CreateTrigger (CLRegion region, bool repeats);
}

interface IUNUserNotificationCenterDelegate { }
Expand Down