[linker] Fix "Linked Away" exceptions with Thread.CurrentPrincipal. Fix #7321 #7510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xamarin#7321 Keep 'CallContextSecurityData' around since it's quite small (and the normal linker logic will be able to deal with it if unused) and allows the use of `Thread.CurrentPrincipal` Also add unit test. Fix xamarin#7321
|
Build failure Test results1 tests failed, 88 tests passed.Failed tests
|
rolfbjarne
approved these changes
Nov 28, 2019
|
failure is a known issue, HE0038 on watchOS https://github.com/xamarin/maccore/issues/581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep 'CallContextSecurityData' around since it's quite small (and the
normal linker logic will be able to deal with it if unused) and allows
the use of
Thread.CurrentPrincipalAlso add unit test.
Fix #7321