Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foundation] Add bindings for NSBackgroundActivityScheduler #7496

Merged

Conversation

prmallic
Copy link
Contributor

Addresses #7224

@prmallic prmallic marked this pull request as ready for review November 26, 2019 19:19
Comment on lines +16634 to +16635
[Export ("scheduleWithBlock:")]
void Schedule (NSBackgroundActivityCompletionAction action);
Copy link

@ghost ghost Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (not feedback): During team week @dalexsoto mentioned the Async attribute should be used when the last argument of a method is a callback. Why isn't async used here, isn't this method asynchronous in objc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wachaudh because in this case, it is not a function to be called when the method is completed with the result of the operation, but a function to be schedule to be called.

That is, if the callback taken by the function is going to be called with the results of the function, you should use Async. In this case you are just giving a function to be schedule.

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 86 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed

@prmallic
Copy link
Contributor Author

Known failure HE0038

@prmallic prmallic merged commit faf1275 into xamarin:master Nov 27, 2019
@tipa
Copy link

tipa commented Feb 11, 2020

Is there any timeline when this new bindings will make it to the stable version of Xamarin.MacOS?

@chamons
Copy link
Contributor

chamons commented Feb 11, 2020

Good question. You can read about our release process here.

This is currently in our d16-6 branch, which will be two releases from now.

Today

Current: d16-4
Preview: d16-5

Branching for d16-5 was done on Oct 28, which was a month before this landed.

There is not currently an announced date for d16-6 to go summer, but you can likely expect it to be a number of months.

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants