Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d16-5][msbuild] Makes DSymUtil task report the Executable as output #7340

Merged
merged 1 commit into from
Oct 30, 2019

Commits on Oct 30, 2019

  1. [msbuild] Makes DSymUtil task report the Executable as output

    The DSymUtil tool not only generates the debug symbol files but also modifies the executable file. Marking that property as Output (and changing it to ITaskItem type) makes Visual Studio on Windows aware of that change. Under certain scenarios this was making the build on VS produce an app bundle that was not fully signed on incremental builds. For instance, the DSymUtil task was run for a framework on an incremental build, but as the executable file of that framework was not modified on Windows the inputs/outputs check for CodesignFrameworks did not fail so that target was skipped. This led to a failure on the CodesignVerify target.
    
    Partial fix for https://developercommunity.visualstudio.com/content/problem/729766/codedesign-exited-with-code-1.html
    emaf committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    a3b9e08 View commit details
    Browse the repository at this point in the history