Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the mono archive again. #7096

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Use the mono archive again. #7096

merged 1 commit into from
Sep 25, 2019

Conversation

rolfbjarne
Copy link
Member

No description provided.

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    Failed to update apidiff references
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

@rolfbjarne rolfbjarne added the skip-api-comparison Skips API / generator diffs when testing pull requests label Sep 25, 2019
@rolfbjarne
Copy link
Member Author

build

spouliot
spouliot approved these changes Sep 25, 2019
View reviewed changes
tools/install-source/Program.cs

if (!File.Exists (fixedSource))
fixedSource = mangler.GetSourcePath (src);
var fixedSource = mangler.GetSourcePath (src);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why is this needed now ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a revert of this fix, which turned out to be wrong: cf12606.

@monojenkins
Copy link
Collaborator

Build success
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
✅ Test run succeeded

@rolfbjarne
Copy link
Member Author

I skipped the api comparison because when checking out the previous commit to build it, the previous hash was the mono archive disabled, and the api comparison tries to find mono-api-info.exe from the mono submodule, which ends up failing because the mono submodule isn't there.

@rolfbjarne rolfbjarne merged commit 46fbc83 into xamarin:master Sep 25, 2019
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes skip-api-comparison Skips API / generator diffs when testing pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rolfbjarne @monojenkins @spouliot @mandel-macaque