-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Move linker tests from maccore #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build success |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Apr 4, 2019
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 6, 2020
New commits in xamarin/Xamarin.MacDev: * xamarin/Xamarin.MacDev@a0a11af Adjust SDK validation to allow tools/bin and not allow usr/bin. (xamarin#71) * xamarin/Xamarin.MacDev@e21e1aa Accept 'tools/buildinfo' as an alternative path to 'buildinfo' due to an nuget bug. (xamarin#70) * xamarin/Xamarin.MacDev@ce24236 Don't look in /Developer/MonoTouch anymore, there's nothing there. (xamarin#69) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/210c664e56117d3a1a7f6dd002109eb444dbdc17..a0a11aff271565bbaba029e5e428a0b9c2ca0e37
Merged
rolfbjarne
added a commit
that referenced
this pull request
Mar 9, 2020
* Bump Xamarin.MacDev. New commits in xamarin/Xamarin.MacDev: * xamarin/Xamarin.MacDev@a0a11af Adjust SDK validation to allow tools/bin and not allow usr/bin. (#71) * xamarin/Xamarin.MacDev@e21e1aa Accept 'tools/buildinfo' as an alternative path to 'buildinfo' due to an nuget bug. (#70) * xamarin/Xamarin.MacDev@ce24236 Don't look in /Developer/MonoTouch anymore, there's nothing there. (#69) Diff: https://github.com/xamarin/Xamarin.MacDev/compare/210c664e56117d3a1a7f6dd002109eb444dbdc17..a0a11aff271565bbaba029e5e428a0b9c2ca0e37 * [msbuild] Teach tests that mock MonoTouchSdk to mock better. MonoTouchSdk ends up a bit confused when giving it an Sdk directory that isn't a real Sdk directory, and then assuming that properties that return Sdk paths won't throw exceptions. Fix this by giving MonoTouchSdk a better fake Sdk directory (which MonoTouchSdk detects as a real Sdk directory), and thus those previously mentioned properties will return true fake values instead of throwing exceptions.
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 14, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@e5a46fd [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@f8d9a21 [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@c151a18 [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@74fbc3f [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@857c584 [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@85f716d [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@8bea179 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@2c2a55e Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@09733ed [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@8f2d02e Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..e5a46fd0a05b3c3c84a0ba013463e957311db6f2
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 14, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 14, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 15, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 15, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 15, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 16, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 16, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 16, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 16, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 17, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..1c272a98ac525f1578d4bd2ee96a8f6c14802152
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 17, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 21, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 21, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 22, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 22, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 22, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 22, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..926673287338482f3949659288ab36001413d251
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 23, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 30, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c
rolfbjarne
added a commit
that referenced
this pull request
Jul 30, 2020
This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 30, 2020
This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 31, 2020
This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@dafdf9f [Touch.Client] Add API to exclude tests based on categories. * xamarin/Touch.Unit@e6fb7d7 [Touch.Client] Fix paths in the .NET project files. * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..dafdf9f44f8fada4e47e2abd0c95c9e494377a8c
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Aug 3, 2020
This also required adding System.Core.dll to the MonoTouch.NUnitLite.dll, and fixing a csproj path. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@f620668 [Touch.Client] Adjust project configurations. (xamarin#83) * xamarin/Touch.Unit@545400b [Touch.Client] Fix paths in the .NET project files. (xamarin#81) * xamarin/Touch.Unit@703586b [Touch.Client] Add API to exclude tests based on categories. (xamarin#82) * xamarin/Touch.Unit@9266732 [Touch.Client] Add support for macOS. (xamarin#80) * xamarin/Touch.Unit@2d556a5 [TouchRunner] Fix network logging to log if we're logging to a file even if EnableNetwork is false. (xamarin#79) * xamarin/Touch.Unit@1f85e16 [TouchOptions] Fix a few issues related to command-line parsing. (xamarin#78) * xamarin/Touch.Unit@1c272a9 [TouchRunner] Rename TestElement.Update to TestElement.TestFinished to make it clearer when it's used. (xamarin#73) * xamarin/Touch.Unit@9a654ca [TouchRunner] Fix running multiple test assemblies in NUnitLite mode. (xamarin#76) * xamarin/Touch.Unit@55c747f [TouchRunner] Print test output to the console. (xamarin#75) * xamarin/Touch.Unit@ab5dce0 [TouchRunner] Keep track of the last shown test suite, and return to it when the app is relaunched. (xamarin#74) * xamarin/Touch.Unit@1a7068c [TouchRunner] Only update the UI for a single test after the test has finished running. (xamarin#72) * xamarin/Touch.Unit@ba93ddf [TouchRunner] Fix unused variable warning by only defining the variable when it's used. (xamarin#71) * xamarin/Touch.Unit@ab2aaa5 [TouchRunner] Always show 'Run all'. (xamarin#70) * xamarin/Touch.Unit@af58317 Move every Touch.Client projects to its own folder. (xamarin#69) * xamarin/Touch.Unit@8a0ec0d [TouchRunner] Improve name printing in NuGet mode. (xamarin#68) * xamarin/Touch.Unit@c7f8ff0 Ignore any 'packages' directory. (xamarin#67) Diff: https://github.com/spouliot/Touch.Unit/compare/b4e8606a85255f2456b0b20d5a0732298fa1ad36..f62066880ae548bac9302d714b8c045955051014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.