[foundation] Add support for NSValue/CGAffineTransform and StoreValueAtAddress overload #6887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AtAddress overload Support for `NSValue`/`CGAffineTransform` exists in iOS/tvOS/watchOS, from UIKit, but not for macOS. However this will be required for the new protocols inside CoreImage. Also add an overload for `StoreValueAtAddress` since the original one was deprecated but we did not provide the new alternative to update the code.
rolfbjarne
approved these changes
Aug 30, 2019
| extern static IntPtr xamarin_encode_CGAffineTransform (); | ||
|
|
||
| // The `+valueWithCGAffineTransform:` selector comes from UIKit and is not available on macOS | ||
| public unsafe static NSValue FromCGAffineTransform (CGAffineTransform tran) |
There was a problem hiding this comment.
Style: complete word as parameter name - transform
There was a problem hiding this comment.
yeah, I thought about it - but it's the current name for iOS/tvOS/watchOS :(
so I decided to be consistent
|
Build failure 🔥 Build failed 🔥 |
|
Looks like mono's |
|
build |
|
Build failure Test results8 tests failed, 83 tests passed.Failed tests
|
mandel-macaque
approved these changes
Aug 30, 2019
dalexsoto
approved these changes
Aug 30, 2019
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
NSValue/CGAffineTransformexists in iOS/tvOS/watchOS,from UIKit, but not for macOS. However this will be required for the
new protocols inside CoreImage.
Also add an overload for
StoreValueAtAddresssince the originalone was deprecated but we did not provide the new alternative to
update the code.