[mtouch] Set default for dlsym to false for iOS (like tvOS and watchOS) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cycle 7 we turned off, by default, the `dlsym` option (i.e. looking up symbols for p/invoke) for tvOS and watchOS. However we decided to wait for iOS to see if this caused issues for existing code base. There has not been such reports (for tvOS) so, for cycle 8, we'll turn it off (and use direct calls) for iOS. If problems arise during the alpha/beta of C8 then we still can revert this change easily.
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Apr 3, 2019
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jun 2, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@6c5bb93 [Touch.Client] Add net5 project files. (xamarin#65) * xamarin/Touch.Unit@ef92ff9 Add tvOS version of Touch.Client. (xamarin#64) * xamarin/Touch.Unit@705964d [Touch.Client] Add a client that uses MonoTouch.Dialog and NUnitLite from NuGet. (xamarin#63) * xamarin/Touch.Unit@fbf9f30 Port Touch.Unit to the Unified profile, and remove the NUnitLite tests from the monotouch.tests project. (xamarin#62) * xamarin/Touch.Unit@dfbf8cb [TouchRunner] Update the current element even if showing a sub element with failure info. (xamarin#61) * xamarin/Touch.Unit@d5b1caa [TouchRunner] TestFinished may be called on a background thread, so make sure to execute any UI logic on the main thread. (xamarin#60) * xamarin/Touch.Unit@ba1196f Convert existing projects to Xamarin.iOS/Unified. (xamarin#58) * xamarin/Touch.Unit@f6958a2 Remove code to be compatible with MonoTouch (Classic Xamarin.iOS). (xamarin#59) * xamarin/Touch.Unit@6a10d44 Remove CLSCompliant attribute which causes compiler warnings. (xamarin#57) Diff: https://github.com/spouliot/Touch.Unit/compare/9db795d50d9fe4ac5df77d3f0d85c1b84d32ce8c..6c5bb930b35cf326d1f650eac0a5ac9e679a4e09
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jun 2, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@6c5bb93 [Touch.Client] Add net5 project files. (xamarin#65) * xamarin/Touch.Unit@ef92ff9 Add tvOS version of Touch.Client. (xamarin#64) * xamarin/Touch.Unit@705964d [Touch.Client] Add a client that uses MonoTouch.Dialog and NUnitLite from NuGet. (xamarin#63) * xamarin/Touch.Unit@fbf9f30 Port Touch.Unit to the Unified profile, and remove the NUnitLite tests from the monotouch.tests project. (xamarin#62) * xamarin/Touch.Unit@dfbf8cb [TouchRunner] Update the current element even if showing a sub element with failure info. (xamarin#61) * xamarin/Touch.Unit@d5b1caa [TouchRunner] TestFinished may be called on a background thread, so make sure to execute any UI logic on the main thread. (xamarin#60) * xamarin/Touch.Unit@ba1196f Convert existing projects to Xamarin.iOS/Unified. (xamarin#58) * xamarin/Touch.Unit@f6958a2 Remove code to be compatible with MonoTouch (Classic Xamarin.iOS). (xamarin#59) * xamarin/Touch.Unit@6a10d44 Remove CLSCompliant attribute which causes compiler warnings. (xamarin#57) Diff: https://github.com/spouliot/Touch.Unit/compare/9db795d50d9fe4ac5df77d3f0d85c1b84d32ce8c..6c5bb930b35cf326d1f650eac0a5ac9e679a4e09
Merged
rolfbjarne
added a commit
that referenced
this pull request
Jun 2, 2020
New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@6c5bb93 [Touch.Client] Add net5 project files. (#65) * xamarin/Touch.Unit@ef92ff9 Add tvOS version of Touch.Client. (#64) * xamarin/Touch.Unit@705964d [Touch.Client] Add a client that uses MonoTouch.Dialog and NUnitLite from NuGet. (#63) * xamarin/Touch.Unit@fbf9f30 Port Touch.Unit to the Unified profile, and remove the NUnitLite tests from the monotouch.tests project. (#62) * xamarin/Touch.Unit@dfbf8cb [TouchRunner] Update the current element even if showing a sub element with failure info. (#61) * xamarin/Touch.Unit@d5b1caa [TouchRunner] TestFinished may be called on a background thread, so make sure to execute any UI logic on the main thread. (#60) * xamarin/Touch.Unit@ba1196f Convert existing projects to Xamarin.iOS/Unified. (#58) * xamarin/Touch.Unit@f6958a2 Remove code to be compatible with MonoTouch (Classic Xamarin.iOS). (#59) * xamarin/Touch.Unit@6a10d44 Remove CLSCompliant attribute which causes compiler warnings. (#57) Diff: https://github.com/spouliot/Touch.Unit/compare/9db795d50d9fe4ac5df77d3f0d85c1b84d32ce8c..6c5bb930b35cf326d1f650eac0a5ac9e679a4e09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cycle 7 we turned off, by default, the
dlsymoption (i.e. lookingup symbols for p/invoke) for tvOS and watchOS.
However we decided to wait for iOS to see if this caused issues for
existing code base. There has not been such reports (for tvOS) so,
for cycle 8, we'll turn it off (and use direct calls) for iOS.
If problems arise during the alpha/beta of C8 then we still can
revert this change easily.