[mmp] Remove duplicate libmono-system-native.a logic #5073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chamons
commented
Nov 1, 2018
chamons
commented
- [mmp] Include libmono-system-native.a when embedding mono if it exists #4980 and the mono branch merge both added it
- However both copies were not the same, one was conditional and one added an extra -u option
- This collapses them into one check
- xamarin#4980 and the mono branch merge both added it - However both copies were not the same, one was conditional and one added an extra -u option - This collapses them into one check
|
Hat tip to @alanmcgovern for catching this. |
chamons
referenced
this pull request
Nov 1, 2018
spouliot
approved these changes
Nov 1, 2018
|
Build failure Test results1 tests failed, 0 tests skipped, 81 tests passed.Failed tests
|
rolfbjarne
approved these changes
Nov 2, 2018
|
Test failed due to watch crash - https://github.com/xamarin/maccore/issues/1017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.