Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Avoid possible NullReferenceException in ScnToolTaskBase. Fixes #4039 #5006

Merged
merged 1 commit into from
Oct 18, 2018
Merged

[msbuild] Avoid possible NullReferenceException in ScnToolTaskBase. Fixes #4039 #5006

merged 1 commit into from
Oct 18, 2018

Commits on Oct 18, 2018

  1. [msbuild] Avoid possible NullReferenceException in ScnToolTaskBase. F… 

    …ixes xamarin#4039

`EnvironmentVariables` can be null (not empty) and cause the NRE in the
attached test case.

It's not clear that the extra logic is needed if we were using `xcrun`.
There's an enhancement for this xamarin#4634

reference: xamarin#4039
    @spouliot
    spouliot committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    7d20d51 View commit details
    Browse the repository at this point in the history