Bump to mono:2017-12

[luhenry]

No description provided.

[rolfbjarne]

This looks like debug spew

[rolfbjarne]

Debug spew?

[monojenkins]

Build failure

[spouliot]

this will need to be merged first (once it's all green) on maccore

[luhenry]

Do you want to go through a PR as well for xamarin/maccore?

[spouliot]

yes, but there's no build on maccore so it can be fast - mostly just reviewing the changes. The original ones were minor, only mono-extensions bump, but could not be merged ahead of time since it broke with 2017-10

[monojenkins]

Build failure

[luhenry]

See https://github.com/xamarin/maccore/pull/631

[spouliot]

[FAIL] TimeZoneTest.TestCtors : D02 -> known failure https://github.com/xamarin/maccore/issues/629

[spouliot]

@luhenry sounds like Jenkins tells us it's ready to merge :) Please let us know if/when XA is ready
@rolfbjarne any last word (like devices on bots) ?

[rolfbjarne]

The last completed device build is 7 days old (there should be another one in a day or so).

The changes are fine with me, but there are multiple issues on Jenkins:

1. Api diff shows a few breaking changes in System.Data.dll:

2. link all, link sdk and monotouch-test crash in all simulators due to an unhandled exception:

Feb  8 07:16:21 xam-mac-mini-5 monotouchtest[86072]: 
	Unhandled Exception:
	System.NullReferenceException: Object reference not set to an instance of an object
	  at NUnitLite.Runner.ResultSummary.Visit (NUnit.Framework.Api.ITestResult result) [0x00000] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/ResultSummary.cs:140 
	  at NUnitLite.Runner.ResultSummary..ctor (NUnit.Framework.Api.ITestResult result) [0x00006] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/ResultSummary.cs:52 
	  at NUnitLite.Runner.NUnit2XmlOutputWriter.InitializeXmlFile (NUnit.Framework.Api.ITestResult result) [0x00000] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/OutputWriters/NUnit2XmlOutputWriter.cs:109 
	  at NUnitLite.Runner.NUnit2XmlOutputWriter.WriteXmlOutput (NUnit.Framework.Api.ITestResult result, System.Xml.XmlWriter xmlWriter) [0x00007] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/OutputWriters/NUnit2XmlOutputWriter.cs:102 
	  at NUnitLite.Runner.NUnit2XmlOutputWriter.WriteResultFile (NUnit.Framework.Api.ITestResult result, System.IO.TextWriter writer) [0x0000e] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/mono/external/nunit-lite/NUnitLite-1.0.0/src/framework/Runner/OutputWriters/NUnit2XmlOutputWriter.cs:90 
	  at MonoTouch.NUnit.NUnitOutputTextWriter.Close () [0x000bc] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/NUnitOutputTextWriter.cs:99 
	  at MonoTouch.NUnit.UI.BaseTouchRunner.CloseWriter () [0x0006c] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:354 
	  at MonoTouch.NUnit.UI.BaseTouchRunner.Run () [0x0003f] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:173 
	  at MonoTouch.NUnit.UI.BaseTouchRunner.<AutoRun>b__40_0 () [0x00000] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:139 
	  at MonoTouch.NUnit.UI.TouchRunner+<>c__DisplayClass19_0.<ExecuteOnMainThread>b__0 () [0x00000] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/external/Touch.Unit/NUnitLite/TouchRunner/TouchRunner.cs:685 
	  at Foundation.NSAsyncActionDispatcher.Apply () [0x00000] in /Library/Frameworks/Xamarin.iOS.framework/Versions/11.9.0.158/src/Xamarin.iOS/Foundation/NSAction.cs:125 
	--- End of stack trace from previous location where exception was thrown ---
	  at (wrapper managed-to-native) UIKit.UIApplication.UIApplicationMain(int,string[],intptr,intptr)
	  at UIKit.UIApplication.Main (System.String[] args, System.IntPtr principal, System.IntPtr delegate) [0x00005] in /Library/Frameworks/Xamarin.iOS.framework/Versions/11.9.0.158/src/Xamarin.iOS/UIKit/UIApplication.cs:79 
	  at UIKit.UIApplication.Main (System.String[] args, System.String principalClassName, System.String delegateClassName) [0x00038] in /Library/Frameworks/Xamarin.iOS.framework/Versions/11.9.0.158/src/Xamarin.iOS/UIKit/UIApplication.cs:63 
	  at monotouchtest.Application.Main (System.String[] args) [0x00011] in /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/monotouch-test/Main.cs:28 

[spouliot]

@EgorBo @marek-safar were you aware of System.Data breaking changes ? the override are likely correct but the property is problematic (for binaries using it)

@rolfbjarne weird for linker issues that are device only - but that's likely something on our side to fix (not blocking).

[spouliot]

my bad, the linker tests fails on simulators too (in this PR) the way jenklns reports errors is not optimal :(

[marek-safar]

@rolfbjarne @spouliot good find we were still missing few but this mono/mono#6913 should fix it.

[monojenkins]

Build failure

[rolfbjarne]

New results from the device tests are in (for commit 59f5ed4), and the only issue is that watchOS/Release builds fail with:

MTOUCH: error MT5210: Native linking failed, undefined symbol: _mono_aot_MonoTouch_NUnitLiteweak_field_indexes. Please verify that all the necessary frameworks have been referenced and native libraries are properly linked in. 
MTOUCH: error MT5210: Native linking failed, undefined symbol: _mono_aot_System_Coreweak_field_indexes. Please verify that all the necessary frameworks have been referenced and native libraries are properly linked in. 
MTOUCH: error MT5210: Native linking failed, undefined symbol: _mono_aot_System_Xmlweak_field_indexes. Please verify that all the necessary frameworks have been referenced and native libraries are properly linked in. 
MTOUCH: error MT5210: Native linking failed, undefined symbol: _mono_aot_Systemweak_field_indexes. Please verify that all the necessary frameworks have been referenced and native libraries are properly linked in. 
MTOUCH: error MT5210: Native linking failed, undefined symbol: _mono_aot_Xamarin_WatchOSweak_field_indexes. Please verify that all the necessary frameworks have been referenced and native libraries are properly linked in. 
MTOUCH: error MT5210: Native linking failed, undefined symbol: _mono_aot_dont_linkweak_field_indexes. Please verify that all the necessary frameworks have been referenced and native libraries are properly linked in. 
MTOUCH: error MT5210: Native linking failed, undefined symbol: _mono_aot_mscorlibweak_field_indexes. Please verify that all the necessary frameworks have been referenced and native libraries are properly linked in. 

[spouliot]

@vargaz could the _mono_aot_*weak_field_indexes be missing in bitcore/llvm generation ?

[vargaz]

Its not clear why those are not found, they are emitted like every other symbol. I'll look at those after this is merged.

[monojenkins]

Build failure

[monojenkins]

Build failure

[vargaz]

The watchos failures will be fixed by:
mono/mono#7007

[spouliot]

LinkAllRegressionTest.AssemblyReferences_16213 failure filed as #3480 and will be fixed post-merge