Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVFoundation] Implement AVCapturePhoto. Partially fixes #59388. #2678

Merged
merged 2 commits into from
Sep 13, 2017

Conversation

rolfbjarne
Copy link
Member

Fixes:

common.unclassified:!missing-type! AVCapturePhoto not bound

https://bugzilla.xamarin.com/show_bug.cgi?id=59388

CVPixelBuffer PreviewPixelBuffer { get; }

[NullAllowed, Export ("embeddedThumbnailPhotoFormat")]
NSDictionary<NSString, NSObject> EmbeddedThumbnailPhotoFormat { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sold on this being the generic version of the NSDictionary since we might want to turn this into a StrongDictionary at some point seems that the possible values are here to be found https://developer.apple.com/documentation/avfoundation/avassetwriterinput/video_settings_dictionaries?language=objc maybe just NSDictionary WeakEmbeddedThumbnailPhotoFormat { get; } so it is easily wrapped by the StrongDictionary generator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalexsoto I've fixed this now (and Metadata as well).

@monojenkins
Copy link
Collaborator

Build success

Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be missing pieces

!missing-selector! AVCapturePhoto::bracketSettings not bound
!missing-selector! AVCapturePhoto::fileDataRepresentationWithReplacementMetadata:replacementEmbeddedThumbnailPhotoFormat:replacementEmbeddedThumbnailPixelBuffer:replacementDepthData: not bound
!missing-selector! AVCapturePhoto::lensStabilizationStatus not bound
!missing-selector! AVCapturePhoto::sequenceCount not bound

^ since those comes from tvOS xtro results my guess is that's it's a category (which is not marked as iOS only)

@rolfbjarne
Copy link
Member Author

@spouliot I've fixed the tvOS xtro results in PR #2682.

…d AVCapturePhoto.EmbeddedThumbnailPhotoFormat.
@monojenkins
Copy link
Collaborator

Build success

@spouliot spouliot merged commit 41d1fe7 into xamarin:xcode9 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants