Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macos] Fix 5 methods on NSApplication which were added to the wrong … #2474

Merged
merged 1 commit into from
Aug 10, 2017
Merged

[macos] Fix 5 methods on NSApplication which were added to the wrong … #2474

merged 1 commit into from
Aug 10, 2017

Conversation

chamons
Copy link
Contributor

@chamons chamons commented Aug 10, 2017

…type (#2470)

  • https://bugzilla.xamarin.com/show_bug.cgi?id=57718
  • Unable to move until XAMCORE_4_0 as would be breaking change
  • NSServicesMenuRequestor APIs were never on NSApplication / NSApplicationDelegate
  • RegisterServicesMenu / OrderFrontStandardAboutPanel / OrderFrontStandardAboutPanelWithOptions are only on Application, not delegate

@chamons
[macos] Fix 5 methods on NSApplication which were added to the wrong …
e5dbe5d 
…type (xamarin#2470)

- https://bugzilla.xamarin.com/show_bug.cgi?id=57718
- Unable to move until XAMCORE_4_0 as would be breaking change
- NSServicesMenuRequestor APIs were never on NSApplication / NSApplicationDelegate
- RegisterServicesMenu / OrderFrontStandardAboutPanel / OrderFrontStandardAboutPanelWithOptions are only on Application, not delegate
@chamons
Copy link
Contributor Author

chamons commented Aug 10, 2017

#2470 to 15-4

@monojenkins
Copy link
Collaborator

Build success

@chamons chamons merged commit ece368b into xamarin:d15-4 Aug 10, 2017
@chamons chamons deleted the 15-4-57718 branch August 10, 2017 15:22
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this pull request Jul 26, 2021
@rolfbjarne
Bump maccore.
8f5bf4d 
New commits in xamarin/maccore:

* xamarin/maccore@7e6ffadb1f [Xamarin.Hosting] Only warn if we try to load a framework that doesn't exist. (xamarin#2473)
* xamarin/maccore@cc42300ec4 [Xamarin.Hosting] Xcode 13 b3 doesn't have IBFoundation anymore, but it does have AssetCatalogFoundation, which we must load. (xamarin#2474)
* xamarin/maccore@3e9801ee9a [Xamarin.Hosting] Improve error reporting when dlopen fails (xamarin#2475)

Diff: https://github.com/xamarin/maccore/compare/c67d7af80d005d8a1a4321e4e5d4d148918d960b..7e6ffadb1fe1a8e1444485a9915b04dcc07ab95b
@rolfbjarne rolfbjarne mentioned this pull request Jul 26, 2021
Merged
rolfbjarne added a commit that referenced this pull request Jul 27, 2021
@rolfbjarne
Bump maccore. (#12228)
2566861 
New commits in xamarin/maccore:

* xamarin/maccore@7e6ffadb1f [Xamarin.Hosting] Only warn if we try to load a framework that doesn't exist. (#2473)
* xamarin/maccore@cc42300ec4 [Xamarin.Hosting] Xcode 13 b3 doesn't have IBFoundation anymore, but it does have AssetCatalogFoundation, which we must load. (#2474)
* xamarin/maccore@3e9801ee9a [Xamarin.Hosting] Improve error reporting when dlopen fails (#2475)

Diff: https://github.com/xamarin/maccore/compare/c67d7af80d005d8a1a4321e4e5d4d148918d960b..7e6ffadb1fe1a8e1444485a9915b04dcc07ab95b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chamons @monojenkins @spouliot @dnfclas