[IdentityLookup] Adds Xcode 9 Beta 1 bindings #2273
Conversation
|
Build failure |
|
Keeping this as reference https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/4129/ |
|
build |
| [DisableDefaultCtor] | ||
| [BaseType (typeof (NSExtensionContext))] | ||
| interface ILMessageFilterExtensionContext { | ||
|
|
There was a problem hiding this comment.
I always leave a Whitespace between the interface line definition and the first member definition and this is the first time I've been called out :)
There was a problem hiding this comment.
Probably not a big deal either way, and I don't think there's a policy for it. I never leave the whitespace there, and glancing through a couple of the larger binding files most interfaces seemed to not have it, though looking elsewhere there's plenty that DO have it, so...¯_(ツ)_/¯
| [iOS (11,0)] | ||
| [Protocol] | ||
| interface ILMessageFilterQueryHandling { | ||
|
|
There was a problem hiding this comment.
I always leave a Whitespace between the interface line definition and the first member definition and this is the first time I've been called out :)
|
@timrisi see for example intents https://github.com/xamarin/xamarin-macios/blob/master/src/intents.cs do you have a reference to our coding guidelines where I shouldn't do so? |
|
Don't know of any guidelines. Foundation mostly seems to not have it, so I this is probably one case with no current guideline |
|
Build failure |
|
unrelated failure
|
|
|
||
| [Abstract] | ||
| [Export ("handleQueryRequest:context:completion:")] | ||
| void HandleQueryRequest (ILMessageFilterQueryRequest queryRequest, ILMessageFilterExtensionContext context, Action<ILMessageFilterQueryResponse> completion); |
There was a problem hiding this comment.
that's repeating QueryRequest from the first parameter
but Handle is not very descriptive and already used for a property
can you just double-check the swift name ?
There was a problem hiding this comment.
@spouliot they use handle in swift func handle(ILMessageFilterQueryRequest, context: ILMessageFilterExtensionContext, completion: (ILMessageFilterQueryResponse) -> Void) but Handle on our side has a very special meaning and also can conflict if implemented by a NSObject which will cause additional pain (code) on the users end. Also for readability HandleQueryRequest IMHO is much more descriptive.
I think we can bend our rules a little this time but it is your call 👍
There was a problem hiding this comment.
Thanks, I agree - let's merge that puppy.
…rin#2273 Make the test check against the value returned by the native API rather than expect the result to always be null. Fixes xamarin/maccore#2273
#9276) * [Tests] Fix TryGetSupportedInterfaces when we have values. Fixes #2273 Make the test check against the value returned by the native API rather than expect the result to always be null. Fixes xamarin/maccore#2273 * Address reviews.
No description provided.