Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebKit] Update to Xcode 9 beta 1 #2228

Merged
merged 2 commits into from
Jun 28, 2017
Merged

[WebKit] Update to Xcode 9 beta 1 #2228

merged 2 commits into from
Jun 28, 2017

Conversation

migueldeicaza
Copy link
Contributor

No description provided.

@monojenkins
Copy link
Collaborator

Build failure

rolfbjarne
rolfbjarne reviewed Jun 20, 2017
View reviewed changes
src/wkwebkit.cs Outdated

[Export ("getAvailableContentRuleListIdentifiers:")]
[Async]
void GetAvailableContentRuleListIdentifiers (Action<NSString []> callback);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be better as Action<string[]>? Or does the generator not support that (if so, maybe we should add it)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I did not catch this, thanks for the review.

spouliot
spouliot suggested changes Jun 20, 2017
View reviewed changes
src/wkwebkit.cs Outdated
{
[Static]
[Export ("defaultStore")]
WKContentRuleListStore DefaultStore ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general those defaults are bound as properties

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/wkwebkit.cs Outdated

[Mac (10,13), iOS (11,0)]
[Protocol]
[BaseType (typeof(NSObject))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No BaseType for protocols (only Model needs one)
Normal inheritance, if needed, can be used to extend another protocol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I am getting rusty.

src/wkwebkit.cs Outdated
#if XAMCORE_2_0
[Mac (10,13), iOS (11,0)]
[Protocol]
[BaseType (typeof(NSObject))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

src/wkwebkit.cs Outdated
#endif
[Mac (10,13), iOS (11,0)]
[Protocol]
[BaseType (typeof(NSObject))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

dalexsoto
dalexsoto approved these changes Jun 20, 2017
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comments are addressed

@monojenkins
Copy link
Collaborator

Build failure

@dalexsoto
Copy link
Member

Unrelated failure in monotouch-test 64 bits -> https://bugzilla.xamarin.com/show_bug.cgi?id=57846

@dalexsoto dalexsoto merged commit 31d06f5 into xamarin:xcode9 Jun 28, 2017
dalexsoto added a commit to dalexsoto/xamarin-macios that referenced this pull request Jun 8, 2020
@dalexsoto
[devops] Add Policheck tool to our pipeline
f9738f5 
New commits in xamarin/maccore:

* xamarin/maccore@d2ef9d7ee0 Add PoliCheckExclusions.xml (xamarin#2228)

Diff: https://github.com/xamarin/maccore/compare/4bfce648475f8db1d93b8a9f51a69ad0b8b55930..d2ef9d7ee008e1a07a29396c68df33cc4f02de18
@dalexsoto dalexsoto mentioned this pull request Jun 8, 2020
Merged
dalexsoto added a commit that referenced this pull request Jun 8, 2020
@dalexsoto
[devops] Add Policheck tool to our pipeline (#8800)
33868e4 
New commits in xamarin/maccore:

* xamarin/maccore@d2ef9d7ee0 Add PoliCheckExclusions.xml (#2228)

Diff: https://github.com/xamarin/maccore/compare/4bfce648475f8db1d93b8a9f51a69ad0b8b55930..d2ef9d7ee008e1a07a29396c68df33cc4f02de18
dalexsoto added a commit to dalexsoto/xamarin-macios that referenced this pull request Jun 8, 2020
@dalexsoto
[devops] Add Policheck tool to our pipeline
80556dc 
New commits in xamarin/maccore:

* xamarin/maccore@714066a4b6 Add PoliCheckExclusions.xml (xamarin#2228) (xamarin#2229)

Diff: https://github.com/xamarin/maccore/compare/ef861db73e7c0f74131d08d5afa64841d6b00e0b..714066a4b6b5062b3cfc12db0e79bfde0c3961ac
@dalexsoto dalexsoto mentioned this pull request Jun 8, 2020
Merged
dalexsoto added a commit that referenced this pull request Jun 8, 2020
@dalexsoto
[devops] Add Policheck tool to our pipeline (#8802)
52509f9 
New commits in xamarin/maccore:

* xamarin/maccore@714066a4b6 Add PoliCheckExclusions.xml (#2228) (#2229)

Diff: https://github.com/xamarin/maccore/compare/ef861db73e7c0f74131d08d5afa64841d6b00e0b..714066a4b6b5062b3cfc12db0e79bfde0c3961ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@migueldeicaza @monojenkins @dalexsoto @rolfbjarne @spouliot @dnfclas