Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macos10.13-beta1] FinderSync and MediaLibrary bindings #2219

Merged
merged 15 commits into from
Jun 28, 2017
Merged

[macos10.13-beta1] FinderSync and MediaLibrary bindings #2219

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5d418bc
New FinderSync bindings
Jun 7, 2017
5e2bf05
Bind MediaLibrary changes. Fix spacing in FinderSync
Jun 7, 2017
5a358e7
Add 2 unbound frameworks to the xtro mac exclusions
Jun 7, 2017
bef7606
Fix fields to use string, not nsstring
Jun 14, 2017
0610693
Add NSFileProviderMessageInterface needed for FinderSync
Jun 14, 2017
aca2894
PR Fixes
Jun 14, 2017
4a097d7
Missed one change to drop 'ForItem'
Jun 14, 2017
7807ced
More PR fixes
Jun 14, 2017
2fd87b3
Merge branch 'xcode9' of github.com:xamarin/xamarin-macios into MacBi…
Jun 15, 2017
4070db5
Fix test failure
Jun 15, 2017
91c2990
Merge branch 'xcode9' of github.com:xamarin/xamarin-macios into MacBi…
Jun 22, 2017
229316e
FinderSync beta 2
Jun 26, 2017
68b87ac
Add back async tag
Jun 26, 2017
92711a4
FinderSync beta 2
Jun 27, 2017
20cbc00
Add bug# for MakeListenerEndpoint
Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion src/findersync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

#if XAMCORE_2_0
namespace XamCore.FinderSync {
delegate void GetValuesCompletionHandler (NSDictionary<NSString, NSObject> values, NSError error);

[Mac (10, 10, onlyOn64: true)]
[BaseType (typeof(NSExtensionContext))]
interface FIFinderSyncController : NSSecureCoding, NSCopying
Expand All @@ -27,6 +29,24 @@ interface FIFinderSyncController : NSSecureCoding, NSCopying

[NullAllowed, Export ("selectedItemURLs")]
NSUrl[] SelectedItemURLs { get; }

[Mac (10,13, onlyOn64 : true)]
[Export ("lastUsedDateForItemWithURL:")]
[return: NullAllowed]
NSDate GetLastUsedDate (NSUrl itemUrl);

[Mac (10,13, onlyOn64 : true)]
[Async, Export ("setLastUsedDate:forItemWithURL:completion:")]
void SetLastUsedDate (NSDate lastUsedDate, NSUrl itemUrl, Action<NSError> completion);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Async ?


[Mac (10,13, onlyOn64 : true)]
[Export ("tagDataForItemWithURL:")]
[return: NullAllowed]
NSData GetTagData (NSUrl itemUrl);

[Async, Mac (10,13, onlyOn64 : true)]
[Export ("setTagData:forItemWithURL:completion:")]
void SetTagData ([NullAllowed] NSData tagData, NSUrl itemUrl, Action<NSError> completion);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sync ?

}

[Mac (10, 10, onlyOn64: true)]
Expand Down Expand Up @@ -54,7 +74,25 @@ interface FIFinderSyncProtocol

[Export ("toolbarItemToolTip")]
string ToolbarItemToolTip { get; }
}

[Mac (10,13, onlyOn64 : true)]
[Export ("exportedObjectForMessageInterface:itemURL:error:")]
NSObject GetExportedObject (NSFileProviderMessageInterface messageInterface, NSUrl itemUrl, [NullAllowed] out NSError error);

[Mac (10,13, onlyOn64 : true)]
[Export ("supportedServiceNamesForItemWithURL:")]
string[] SupportedServiceNames (NSUrl itemUrl);

#if FALSE // TODO: Activate after 10.13 foundation APIs have been merged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file a bug about this so that we don't forget?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. I did file a bug, meant to add it to the comment. I'll update it with the bug #

[Mac (10,13, onlyOn64 : true)]
[Export ("makeListenerEndpointForServiceName:andReturnError:")]
[return: NullAllowed]
NSXpcListenerEndpoint MakeListenerEndpoint (string serviceName, [NullAllowed] out NSError error);
#endif
[Mac (10,13, onlyOn64 : true)]
[Async, Export ("valuesForAttributes:forItemWithURL:completion:")]
void GetValues (string[] attributes, NSUrl itemUrl, GetValuesCompletionHandler completion);
}

[Mac (10, 10, onlyOn64: true)]
[BaseType (typeof(NSObject))]
Expand Down
7 changes: 7 additions & 0 deletions src/foundation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14227,4 +14227,11 @@ interface NSMeasurementFormatter : NSSecureCoding {
string ToString (NSUnit unit);
}

[NoWatch, NoTV, Mac (10,13), iOS (11,0)]
[BaseType (typeof(NSObject))]
interface NSFileProviderMessageInterface : NSSecureCoding
{
[Export ("name")]
string Name { get; }
}
}
12 changes: 12 additions & 0 deletions src/medialibrary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,18 @@ interface MediaLibraryTypeIdentifierKey {
[Field ("MLPhotosFrontCameraGroupTypeIdentifier")]
NSString PhotosFrontCameraGroupTypeIdentifier { get; }

[Mac (10,13, onlyOn64 : true)]
[Field ("MLPhotosLivePhotosGroupTypeIdentifier")]
NSString PhotosLivePhotosGroupTypeIdentifier { get; }

[Mac (10,13, onlyOn64 : true)]
[Field ("MLPhotosLongExposureGroupTypeIdentifier")]
NSString PhotosLongExposureGroupTypeIdentifier { get; }

[Mac (10,13, onlyOn64 : true)]
[Field ("MLPhotosAnimatedGroupTypeIdentifier")]
NSString PhotosAnimatedGroupTypeIdentifier { get; }

[Mac (10,10, onlyOn64 : true)]
[Field ("MLPhotosPanoramasGroupTypeIdentifier")]
NSString PhotosPanoramasGroupTypeIdentifier { get; }
Expand Down
2 changes: 1 addition & 1 deletion tests/xtro-sharpie/Runner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class ModuleExclusionList {
"IOBluetooth", "IOBluetoothUI", "PubSub", "CryptoTokenKit", "DiscRecording", "DiscRecordingUI", "ImageCaptureCore", "OSAKit", "AudioVideoBridging", "Automator", "ImageCapture",

// Maybe?
"ICADevices", "OpenDirectory", "IMServicePlugIn", "PreferencePanes", "ScreenSaver",
"ICADevices", "OpenDirectory", "IMServicePlugIn", "PreferencePanes", "ScreenSaver", "CoreMediaIO", "SecurityInterface",

// Nope
"InstallerPlugins", "JavaVM", "ExceptionHandling", "JavaFrameEmbedding",
Expand Down