[AVKit] Update to Xcode 9 beta 1 #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure |
spouliot
approved these changes
Jun 11, 2017
| @@ -425,6 +488,22 @@ interface AVKitMetadataIdentifier { | |||
| NSString ExternalUserProfileIdentifier { get; } | |||
| [Field ("AVKitMetadataIdentifierPlaybackProgress")] | |||
| NSString PlaybackProgress { get; } | |||
|
|
|||
| [TV (11,0)] | |||
There was a problem hiding this comment.
Is that under a tvOS only define ?
There was a problem hiding this comment.
Yup
[Static]
[NoiOS, TV (10,1), NoWatch, NoMac]
interface AVKitMetadataIdentifier {
|
Build failure |
src/avkit.cs
Outdated
| @@ -134,6 +139,16 @@ interface AVPlayerViewController { | |||
| [Export ("updatesNowPlayingInfoCenter")] | |||
| bool UpdatesNowPlayingInfoCenter { get; set; } | |||
|
|
|||
| [iOS (11, 0)] | |||
There was a problem hiding this comment.
Minor comment [iOS (11,0)] is prettier (note: you're sometimes not adding a space in this diff).
VincentDondain
approved these changes
Jun 12, 2017
VincentDondain
approved these changes
Jun 12, 2017
|
Build success |
dalexsoto
added a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
May 21, 2020
New commits in xamarin/maccore: * xamarin/maccore@4bfce64847 Update README.md * xamarin/maccore@24682998f7 [devops] Enhance Xcode renaming script (xamarin#2206) * xamarin/maccore@e03f16b862 [Localization][Mlaunch] Fix watchos timeout issue (xamarin#2196) Diff: https://github.com/xamarin/maccore/compare/ad1696d6f33badd34f930e4ce1be9185b5a36dd7..4bfce648475f8db1d93b8a9f51a69ad0b8b55930
dalexsoto
added a commit
that referenced
this pull request
May 21, 2020
…8643) New commits in xamarin/maccore: * xamarin/maccore@4bfce64847 Update README.md * xamarin/maccore@24682998f7 [devops] Enhance Xcode renaming script (#2206) * xamarin/maccore@e03f16b862 [Localization][Mlaunch] Fix watchos timeout issue (#2196) Diff: https://github.com/xamarin/maccore/compare/ad1696d6f33badd34f930e4ce1be9185b5a36dd7..4bfce648475f8db1d93b8a9f51a69ad0b8b55930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.