[ios11-b1] CoreGraphics bindings #2181

migueldeicaza · 2017-06-07T06:17:53Z

No description provided.

monojenkins · 2017-06-07T10:24:15Z

Build failure

spouliot · 2017-06-07T13:16:19Z

src/CoreGraphics/CGPDFDocument.cs

@@ -258,6 +258,34 @@ public CGPDFDictionary GetInfo ()
 		{
 			return new CGPDFDictionary (CGPDFDocumentGetInfo (handle));
 		}
+
+		[DllImport (Constants.CoreGraphicsLibrary)]
+		extern static void CGPDFContextSetOutline (/* CGPDFDocumentRef */ IntPtr document, IntPtr /* dictionary */ outline);


Without availability attributes this will fails tests

spouliot · 2017-06-07T13:18:24Z

src/CoreGraphics/CGContext.cs

@@ -579,6 +579,15 @@ public void EOClip ()
 		}

 		[DllImport (Constants.CoreGraphicsLibrary)]
+		extern static void CGContextResetClip (/* CGContextRef */ IntPtr c);


Is this avail on macOS, tvOS and watchOS?
Needs avail attribute for intro tests

spouliot · 2017-06-07T13:19:04Z

src/CoreGraphics/CGPath.cs

+
+                static PathApplyProxy static_apply;
+
+                delegate void PathApplyProxy (IntPtr block, IntPtr element);


Incorrect alignment, mixing spaces and tabs ?

spouliot · 2017-06-07T13:20:02Z

src/coregraphics.cs

+
+		[Internal]
+		[Field ("kCGColorConversionTRCSize")]
+		NSString TrcSize { get; }


Needs avail attribute

spouliot · 2017-06-07T13:20:41Z

src/coregraphics.cs

 	}

 	[iOS (10,0)][TV (10,0)][Watch (3,0)][Mac (10,12)]
 	[StrongDictionary ("CGColorConversionInfo")]
 	interface CGColorConversionOptions {
 		bool BlackPointCompensation { get; set; }
+		//CGSize TrcSize { get; set; }


Why commented?

Needs further work in generator.cs

@dalexsoto can you file a bug for above ? And assign it to yourself :) thanks

Done https://bugzilla.xamarin.com/show_bug.cgi?id=57569

@migueldeicaza surround it with XAMCORE_2_0 and it will build

#if XAMCORE_2_0 CGSize TrcSize { get; set; } #endif

monojenkins · 2017-06-09T02:09:33Z

Build failure

rolfbjarne

All the manual bindings also need tests.

rolfbjarne · 2017-06-15T11:07:13Z

src/CoreGraphics/CGPDFDocument.cs

@@ -258,6 +258,36 @@ public CGPDFDictionary GetInfo ()
 		{
 			return new CGPDFDictionary (CGPDFDocumentGetInfo (handle));
 		}
+
+		[DllImport (Constants.CoreGraphicsLibrary


Missing )] at the end of the line.

monojenkins · 2017-06-21T03:37:45Z

Build failure

spouliot · 2017-06-23T17:05:17Z

src/CoreGraphics/CGContext.cs

+		[iOS (11,0), Mac(10,3), TV(11,0), Watch(4,0)]
+		extern static void CGContextResetClip (/* CGContextRef */ IntPtr c);
+
+		[iOS (11,0)]


[iOS (11,0), Mac(10,3), TV(11,0), Watch(4,0)] should match p/invoke
or developers won't have the correct information displayed in the IDE

spouliot · 2017-06-23T17:05:59Z

src/CoreGraphics/CGPDFDocument.cs

+		[iOS (11,0), Mac(10,3), TV(11,0), Watch(4,0)]
+		extern static void CGPDFContextSetOutline (/* CGPDFDocumentRef */ IntPtr document, IntPtr /* dictionary */ outline);
+
+		public void SetOutline (CGPDFOutlineOptions options)


[iOS (11,0), Mac(10,3), TV(11,0), Watch(4,0)] for IDE

spouliot · 2017-06-23T17:06:12Z

src/CoreGraphics/CGPDFDocument.cs

+		extern static /* CFDictionaryPtry */ IntPtr CGPDFDocumentGetOutline (/* CGPDFDocumentRef */ IntPtr document);
+
+		[iOS (11,0), Mac(10,3)]
+		public CGPDFOutlineOptions GetOutline ()


[iOS (11,0), Mac(10,3), TV(11,0), Watch(4,0)]

spouliot · 2017-06-23T17:06:32Z

src/CoreGraphics/CGPDFDocument.cs

+			return new CGPDFOutlineOptions (new NSDictionary (ptr));
+		}
+
+		[DllImport (Constants.CoreGraphicsLibrary)]


[iOS(11,0), Mac(10,3)] for intro tests

spouliot · 2017-06-23T17:07:12Z

src/CoreGraphics/CGPath.cs

+
+#if !COREBUILD
+		[DllImport (Constants.CoreGraphicsLibrary)]
+		unsafe extern static void CGPathApplyWithBlock (IntPtr handle, BlockLiteral *blockEnumerator);


missing availability attributes for intro tests

spouliot · 2017-06-23T17:07:33Z

src/CoreGraphics/CGPath.cs

+			}
+		}
+
+		public void Apply (Action<CGPathElement> block)


missing availability attributes for IDE

monojenkins · 2017-06-27T01:55:34Z

Build failure

rolfbjarne · 2017-06-28T06:09:30Z

src/CoreGraphics/CGPDFDocument.cs

+		public CGPDFOutlineOptions GetOutline ()
+		{
+			var ptr = CGPDFDocumentGetOutline (handle);
+			return new CGPDFOutlineOptions (new NSDictionary (ptr));


Use Runtime.GetNSObject<NSDictionary> (ptr) instead of new NSDictionary (ptr), since the former will fetch any existing managed NSDictionary instances.

monojenkins · 2017-07-22T01:18:21Z

Build failure

migueldeicaza

Note to self: remove the CGPath.Apply function, which was needed for ObjC users, but we already provide an equivalent version.

monojenkins · 2017-07-22T02:53:08Z

Build failure

monojenkins · 2017-07-22T17:39:41Z

Build failure

rolfbjarne · 2017-08-01T14:45:43Z

src/CoreGraphics/CGColorSpace.cs

+		static void Check11 ()
+		{
+#if MONOMAC || IOS
+			if (PlatformHelper.CheckSystemVersion (11, 0))


macOS 11.0 doesn't exist yet 😄

rolfbjarne · 2017-09-15T11:14:22Z

I'll look into this PR, CoreGraphics changed a bit more (and some changes were reverted) in later betas.

rolfbjarne · 2017-09-28T18:39:10Z

Superseded (and rebased on the xcode9.1 branch) by PR #2812.

[ios11-b1] CoreGraphics bindings

72840d9

dnfclas added the cla-already-signed label Jun 7, 2017

spouliot suggested changes Jun 7, 2017

View reviewed changes

Updated with feedback from Sebastien

e7caeed

rolfbjarne requested changes Jun 15, 2017

View reviewed changes

Fix build, optimize checks

8156226

spouliot suggested changes Jun 23, 2017

View reviewed changes

Add version information

4ce429d

spouliot approved these changes Jun 27, 2017

View reviewed changes

rolfbjarne requested changes Jun 28, 2017

View reviewed changes

migueldeicaza added 2 commits July 21, 2017 19:44

Merge branch 'xcode9' into xcode9-b1-coregraphics

83b18e0

Address comments

204ec5c

Tests

948d14b

migueldeicaza commented Jul 22, 2017

View reviewed changes

Remove Apply code, add special code for typo

0667c08

rolfbjarne requested changes Aug 1, 2017

View reviewed changes

rolfbjarne self-assigned this Sep 15, 2017

rolfbjarne closed this Sep 28, 2017

rolfbjarne mentioned this pull request Sep 28, 2017

[CoreGraphics] Implement CoreGraphics bindings for Xcode 9. #2812

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ios11-b1] CoreGraphics bindings #2181

[ios11-b1] CoreGraphics bindings #2181

migueldeicaza commented Jun 7, 2017

monojenkins commented Jun 7, 2017

spouliot Jun 7, 2017

spouliot Jun 7, 2017

migueldeicaza Jun 9, 2017

spouliot Jun 7, 2017

migueldeicaza Jun 9, 2017

spouliot Jun 7, 2017

spouliot Jun 7, 2017

migueldeicaza Jun 9, 2017

spouliot Jun 16, 2017

dalexsoto Jun 16, 2017

dalexsoto Jun 22, 2017

migueldeicaza Jul 21, 2017

monojenkins commented Jun 9, 2017

rolfbjarne left a comment

rolfbjarne Jun 15, 2017

monojenkins commented Jun 21, 2017

spouliot Jun 23, 2017

spouliot Jun 23, 2017

migueldeicaza Jul 21, 2017

spouliot Jun 23, 2017

spouliot Jun 23, 2017

spouliot Jun 23, 2017

spouliot Jun 23, 2017

monojenkins commented Jun 27, 2017

rolfbjarne Jun 28, 2017

migueldeicaza Jul 21, 2017

monojenkins commented Jul 22, 2017

migueldeicaza left a comment

monojenkins commented Jul 22, 2017

monojenkins commented Jul 22, 2017

rolfbjarne Aug 1, 2017

rolfbjarne commented Sep 15, 2017

rolfbjarne commented Sep 28, 2017


		static PathApplyProxy static_apply;

		delegate void PathApplyProxy (IntPtr block, IntPtr element);

[ios11-b1] CoreGraphics bindings #2181

[ios11-b1] CoreGraphics bindings #2181

Conversation

migueldeicaza commented Jun 7, 2017

monojenkins commented Jun 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jun 9, 2017

rolfbjarne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jun 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jun 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jul 22, 2017

migueldeicaza left a comment

Choose a reason for hiding this comment

monojenkins commented Jul 22, 2017

monojenkins commented Jul 22, 2017

Choose a reason for hiding this comment

rolfbjarne commented Sep 15, 2017

rolfbjarne commented Sep 28, 2017