[PHASE] Add support for Xcode 15 #19104

haritha-mohan · 2023-09-26T20:53:50Z

No description provided.

github-actions · 2023-09-26T20:58:16Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

dalexsoto

After xtro and intro are happy

github-actions · 2023-10-04T21:58:25Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2023-10-04T23:31:46Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: ea8947125c643883d31b538fee35eb6a54ee016d [PR build]

vs-mobiletools-engineering-service2 · 2023-10-04T23:42:15Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-04T23:44:43Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-04T23:45:11Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-04T23:51:01Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

.NET (No breaking changes)

~~iOS~~: (empty diff detected)
tvOS: vsdrops gist (No breaking changes)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ea8947125c643883d31b538fee35eb6a54ee016d [PR build]

vs-mobiletools-engineering-service2 · 2023-10-05T05:32:49Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 233 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ea8947125c643883d31b538fee35eb6a54ee016d [PR build]

rolfbjarne · 2023-10-12T08:08:44Z

tools/common/Frameworks.cs

@@ -646,6 +646,7 @@ public static Frameworks GetwatchOSFrameworks (bool is_simulator_build)
 					{ "Cinematic", "Cinematic", new Version (17, 0), NotAvailableInSimulator },
 					{ "Symbols", "Symbols", 17, 0 },
 					{ "NetworkExtension", "NetworkExtension", 17, 0 },
+		  { "Phase", "PHASE", new Version (17,0), NotAvailableInSimulator },


@haritha-mohan looks like the indentation is off here (spaces instead of tabs?)

haritha-mohan and others added 2 commits September 26, 2023 13:52

[PHASE] Add support for Xcode 15

3aca401

Auto-format source code

c5c40ac

add conditional for tvos and default ctor

4aa0e1c

haritha-mohan marked this pull request as ready for review September 26, 2023 21:59

haritha-mohan requested a review from rolfbjarne as a code owner September 26, 2023 21:59

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Sep 27, 2023

View reviewed changes

dalexsoto approved these changes Sep 28, 2023

View reviewed changes

haritha-mohan and others added 4 commits September 28, 2023 18:45

got xtro passing

2d8ed79

intro and xtro were conflicting, so just ignore api for now

616e3a5

Merge branch 'net8.0-xcode15' into net8.0-xcode15-phase

2b51fe0

Auto-format source code

ea89471

This comment has been minimized.

Sign in to view

haritha-mohan merged commit 9345934 into xamarin:net8.0-xcode15 Oct 5, 2023
49 checks passed

haritha-mohan deleted the net8.0-xcode15-phase branch October 5, 2023 16:50

rolfbjarne reviewed Oct 12, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PHASE] Add support for Xcode 15 #19104

[PHASE] Add support for Xcode 15 #19104

haritha-mohan commented Sep 26, 2023 •

edited

Loading

github-actions bot commented Sep 26, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

github-actions bot commented Oct 4, 2023

vs-mobiletools-engineering-service2 commented Oct 4, 2023

vs-mobiletools-engineering-service2 commented Oct 4, 2023

vs-mobiletools-engineering-service2 commented Oct 4, 2023

vs-mobiletools-engineering-service2 commented Oct 4, 2023

vs-mobiletools-engineering-service2 commented Oct 4, 2023

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 5, 2023

rolfbjarne Oct 12, 2023

[PHASE] Add support for Xcode 15 #19104

[PHASE] Add support for Xcode 15 #19104

Conversation

haritha-mohan commented Sep 26, 2023 • edited Loading

github-actions bot commented Sep 26, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 4, 2023

⚠️ Your code has been reformatted. ⚠️

vs-mobiletools-engineering-service2 commented Oct 4, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 4, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Oct 4, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Oct 4, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Oct 4, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 5, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne Oct 12, 2023

Choose a reason for hiding this comment

haritha-mohan commented Sep 26, 2023 •

edited

Loading