Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src] Exclude more code from .NET to fix compiler warning. #19036

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

rolfbjarne
Copy link
Member

Fixes this:

ObjCRuntime/Dlfcn.cs(102,20): warning CS0649: Field 'Dlfcn.Dl_info.dli_fbase' is never assigned to, and will always have its default value
ObjCRuntime/Dlfcn.cs(103,20): warning CS0649: Field 'Dlfcn.Dl_info.dli_sname' is never assigned to, and will always have its default value
ObjCRuntime/Dlfcn.cs(104,20): warning CS0649: Field 'Dlfcn.Dl_info.dli_saddr' is never assigned to, and will always have its default value
ObjCRuntime/Dlfcn.cs(101,20): warning CS0649: Field 'Dlfcn.Dl_info.dli_fname' is never assigned to, and will always have its default value

The warning is new, after we removed the referencing code from .NET in a recent commit.

Fixes this:

    ObjCRuntime/Dlfcn.cs(102,20): warning CS0649: Field 'Dlfcn.Dl_info.dli_fbase' is never assigned to, and will always have its default value
    ObjCRuntime/Dlfcn.cs(103,20): warning CS0649: Field 'Dlfcn.Dl_info.dli_sname' is never assigned to, and will always have its default value
    ObjCRuntime/Dlfcn.cs(104,20): warning CS0649: Field 'Dlfcn.Dl_info.dli_saddr' is never assigned to, and will always have its default value
    ObjCRuntime/Dlfcn.cs(101,20): warning CS0649: Field 'Dlfcn.Dl_info.dli_fname' is never assigned to, and will always have its default value

The warning is new, after we removed the referencing code from .NET in a recent commit.
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 4101a8ce21793f2b48a721ffc0d937cf501a0be2 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 4101a8ce21793f2b48a721ffc0d937cf501a0be2 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 6 tests failed, 223 tests passed.

Failures

❌ monotouch tests

6 tests failed, 29 tests passed.
  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2775 Passed: 2686 Inconclusive: 3 Failed: 2 Ignored: 87)
  • monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: Failed (Test run failed.
    Tests run: 2772 Passed: 2684 Inconclusive: 3 Failed: 2 Ignored: 86)
  • monotouch-test/Mac [dotnet]/Release [dotnet]: Failed (Test run failed.
    Tests run: 2772 Passed: 2683 Inconclusive: 3 Failed: 2 Ignored: 87)
  • monotouch-test/Mac [dotnet]/Release (all optimizations) [dotnet]: Failed (Test run failed.
    Tests run: 2772 Passed: 2685 Inconclusive: 3 Failed: 2 Ignored: 85)
  • monotouch-test/Mac [dotnet]/Debug (managed static registrar) [dotnet]: Failed (Test run failed.
    Tests run: 2772 Passed: 2684 Inconclusive: 3 Failed: 2 Ignored: 86)
  • monotouch-test/Mac [dotnet]/Release (managed static registrar, all optimizations) [dotnet]: Failed (Test run failed.
    Tests run: 2772 Passed: 2685 Inconclusive: 3 Failed: 2 Ignored: 85)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 3 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
⚠️ mtouch: No tests selected. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4101a8ce21793f2b48a721ffc0d937cf501a0be2 [PR build]

@rolfbjarne
Copy link
Member Author

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2630).

@rolfbjarne rolfbjarne merged commit 0d3d4ff into xamarin:main Sep 18, 2023
@rolfbjarne rolfbjarne deleted the fix-dlfcn-warning branch September 18, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants