-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not include -dead_strip when native linking a NativeAOT object file #18553
Conversation
/cc: @akoeplinger |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
❗ API diff vs stable (Breaking changes).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 92 tests passed 🎉 Tests counts
Pipeline on Agent |
This PR disables passing
-dead_strip
to the native linker in case of NativeAOT runtime to prevent build failures.Additionally, this change affects the size of the application in the following way - measured with
dotnet new maui
app version8.0.0-preview.7.23359.1
:Even though the size of the application regresses, with this change we have a more stable product.
Finally, once this PR gets merged we can open a tracking issue to solve the size regression either by fixing:
Fixes: #18552