[dotnet] Turn class-redirector into a Task #18244

stephen-hawley · 2023-05-08T20:31:33Z

Rework the class-redirector as an MSBuild Task.

rolfbjarne · 2023-05-09T15:21:03Z

tools/class-redirector/class-redirector/ClassRedirectorTask.cs

@@ -0,0 +1,95 @@
+using System;


MSBuild tasks should go in the msbuild/Xamarin.MacDev.Tasks/Tasks directory, together with all our other tasks.

tools/class-redirector/class-redirector/ClassRedirectorTask.cs

tools/class-redirector/class-redirector/class-redirector.csproj

stephen-hawley · 2023-05-15T15:35:54Z

Did I miss anything @rolfbjarne ?

* Make 'ClassMapPath' an ITaskItem, so that it's copied from Windows to Mac before the task is executed. * Subclass 'XamarinTask', which provides the necessary SessionId property for remote execution. * Implement 'ITaskCallback', and make sure to override GetAdditionalItemsToBeCopied to copy all the input assemblies for the rewriter. * Execute remotely when we should.

rolfbjarne · 2023-05-15T17:20:31Z

Did I miss anything @rolfbjarne ?

Sorry for the delay!

I just pushed some changes to make the task able to execute remotely on a Mac when building on Windows.

Also I think it would be a good idea to change the task to not overwrite the input assemblies, but instead create new files - one major reason is that it makes it much easier to do incremental builds, as well as how to cope with an incomplete build (if the user cancels the build half way, there's no way to know how far in the build process we were to resume correctly if the input files are overwritten during the build).

rolfbjarne · 2023-05-17T06:35:48Z

We'll also need to wait for @emaf to review and approve.

emaf · 2023-05-17T15:16:49Z

msbuild/Xamarin.MacDev.Tasks/Tasks/ClassRedirectorTask.cs

+#nullable enable
+
+namespace Xamarin.MacDev.Tasks {
+	public class ClassRedirectorTask : XamarinTask, ITaskCallback {


nit: tasks in the MacDev.Tasks project don't include Task on the class name, or at least that seems to be the case for concrete task implementations.

vs-mobiletools-engineering-service2 · 2023-05-17T21:28:10Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0219706625e34e57a706514fd36d2358c55baaff [PR build]

vs-mobiletools-engineering-service2 · 2023-05-17T21:34:37Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-05-17T21:46:01Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 0219706625e34e57a706514fd36d2358c55baaff [PR build]

vs-mobiletools-engineering-service2 · 2023-05-17T21:48:22Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-05-17T21:49:20Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-05-18T00:53:15Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 227 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 27 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0219706625e34e57a706514fd36d2358c55baaff [PR build]

Turn class-redirector into a Task

415580a

stephen-hawley added not-notes-worthy Ignore for release notes dotnet An issue or pull request related to .NET (6) labels May 8, 2023